Date: Thu, 26 Jul 2018 07:08:58 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Yuri <yuri@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r475335 - head/devel/liteide Message-ID: <20180726070858.GA93790@FreeBSD.org> In-Reply-To: <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org> References: <201807252025.w6PKPsxQ097871@repo.freebsd.org> <20180726064408.GC77261@FreeBSD.org> <32e60b17-116f-e431-872b-903412e4abd1@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 26, 2018 at 12:02:27AM -0700, Yuri wrote:
> On 7/25/18 11:44 PM, Alexey Dokuchaev wrote:
> >> ...
> >> +FLAVORS= qt5 qt4
> >> +FLAVOR?= ${FLAVORS:[1]}
> > Is this line needed in this case?
>
> Section 7.2 of PHB recommends this line:
> https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html
Yes, I know, but as long as you never check against the default FLAVOR,
you don't need it.
> > Because qt5 is default flavor, and you're checking for qt4 first (qt5 is
> > in .else branch) and never for .if ${FLAVOR} == qt5.
>
> Framework checks that flavor is in the list. Here, when flavor isn't
> qt4, it is safe to assume that it is qt5.
Thank you captain. Not sure why you had to explain this, but that does
not change the point that you don't need FLAVOR?=${FLAVORS:[1]}. :U
will protect you from undefined variable, and it would be defined in the
Qt4 case because it's not the default flavor.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180726070858.GA93790>