Date: Tue, 16 Mar 2021 23:10:16 +0100 From: Juraj Lutter <otis@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r568508 - head/devel/node-gyp Message-ID: <2239997E-E3B6-403F-B36D-4326CDF16EFE@FreeBSD.org> In-Reply-To: <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc> References: <202103152102.12FL2tRP068067@repo.freebsd.org> <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 16 Mar 2021, at 22:17, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 > On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote: >> Author: otis >> Date: Mon Mar 15 21:02:55 2021 >> New Revision: 568508 >> URL: https://svnweb.freebsd.org/changeset/ports/568508 >>=20 >> Log: >> Add port: devel/node-gyp: a build frmework for building Node.js = applications. >=20 > A few problems with this, and the next 2 ports added, so putting my > portmgr's hat on. >=20 > We do not add node modules to the ports tree. > We really do not add node modules to the ports tree. >=20 > If an application needs nodes modules to work, then the port for that > application needs to handle the modules installing, and put those in a > private place. >=20 > lib/node_modules is a really aweful place to put this. As a side = note, > if we were to add node modules to the ports tree, which we are not, it > would probably be libdata/node_modules or share/node_modules. >=20 > Please remove those ports. The rationale behind this is: - Upcoming textproc/kibana7 has =E2=80=9Cre2=E2=80=9D node module = bundled, which also contains a re2.node binary module, that (from distribution tarball) can be for = Linux or Darwin. - In order to build re2.node binary component for FreeBSD in poudriere = without need for network access that would otherwise be needed, separate port seemed the = most ellegant way. I value your comment and any hints/advises are welcome. Thanks otis --Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iHUEAREIAB0WIQR9WLqI3W4V0bRHtaAtyIKFszIZVAUCYFEsyAAKCRAtyIKFszIZ VPgFAP43UbcyHAC98g1wbmAwumfUo/ByxxxrvZ058aO59E5UAwD8C813LS+cTDIk 88aj72283NJiIOeGFyA63weDRKRllw4= =3+ty -----END PGP SIGNATURE----- --Apple-Mail=_F0A0BFCB-D68B-4DF3-A6D8-6D0848EF633D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2239997E-E3B6-403F-B36D-4326CDF16EFE>