Date: Tue, 04 Feb 2014 14:36:38 +0000 From: Max Brazhnikov <makc@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: svn-ports-head@freebsd.org, Rusmir Dusko <nemysis@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342510 - head/games/cutemaze Message-ID: <3033718.ko1yqU3EN4@mercury.ph.man.ac.uk> In-Reply-To: <0490893710F9E2B81364BC6A@ogg.in.absolight.net> References: <201402041149.s14BnPX0031911@svn.freebsd.org> <7999310.FuPfOJuxd6@mercury.ph.man.ac.uk> <0490893710F9E2B81364BC6A@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 04 Feb 2014 14:37:07 +0100 Mathieu Arnold wrote: > +--On 4 f=C3=A9vrier 2014 13:05:39 +0000 Max Brazhnikov <makc@freebsd= .org> > wrote: > |=20 > | This part should be reverted. > | Folks, please *review* what makeplist generates and don't commit it= > | blindly. >=20 > I for one would love to have feedback on what the evolved makeplist s= hould > do better :-) It's way too aggressive for PLIST_SUB and this leads to false substitut= ions=20 sometimes. bsd.qt.mk defines a number of QT_*DIR, but not all of them s= hould=20 be used (actually it depends on particular port). We could help makeplist by telling explicitly which substitutions are r= ight, e.g. by specifying OPTIONS_SUB. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3033718.ko1yqU3EN4>