Date: Wed, 27 Feb 2019 23:01:41 +0100 From: Mateusz Piotrowski <0mp@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344518 - head/share/man/man9 Message-ID: <CAD9iB3fv%2BL5z%2B3ws8XhC5UcEYxT9tbNSvygR6B16wZ%2BbEVdQjw@mail.gmail.com> In-Reply-To: <9F0A25DA-E0D2-4F96-91AF-4648367E3E5F@gmail.com> References: <201902251503.x1PF3otL011409@repo.freebsd.org> <9F0A25DA-E0D2-4F96-91AF-4648367E3E5F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 25 Feb 2019 at 16:12, Enji Cooper <yaneurabeya@gmail.com> wrote: > > > On Feb 25, 2019, at 07:03, Mateusz Piotrowski <0mp@freebsd.org> wrote: > > > > Author: 0mp (ports committer) > > Date: Mon Feb 25 15:03:50 2019 > > New Revision: 344518 > > URL: https://svnweb.freebsd.org/changeset/base/344518 > > > > Log: > > Add missing types to the sysctl(9) manual page > > > > Update the diff to include other missing sysctl types found in sysctl.h. > > > > Some of these sysctls are already documented in other pages (e.g > counter(9) > > and ZONE(9)), but they should at least be mentioned here for > completeness. > > > > This patch now documents all of the following: > > - SYSCTL_BOOL/SYSCTL_ADD_BOOL > > - SYSCTL_COUNTER_U64/SYSCTL_ADD_COUNTER_U64 > > - SYSCTL_COUNTER_U64_ARRAY/SYSCTL_ADD_COUNTER_U64_ARRAY > > - SYSCTL_SBINTIME_MSEC/SYSCTL_ADD_SBINTIME_MSEC > > - SYSCTL_SBINTIME_USEC/SYSCTL_ADD_SBINTIME_USEC > > - SYSCTL_UMA_CUR/SYSCTL_ADD_UMA_CUR > > - SYSCTL_UMA_MAX/SYSCTL_ADD_UMA_MAX > [...] > > Modified: > > head/share/man/man9/sysctl.9 > > ... > > > @@ -52,10 +57,15 @@ > > .Nm SYSCTL_ADD_UINT , > > +.Nm SYSCTL_UMA_MAX > > Quick nit: UMA sorts before UQUAD. > > Also, these APIs deserve manpage links via MLINKS. > I'll submit a patch for this soon. Thank you!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD9iB3fv%2BL5z%2B3ws8XhC5UcEYxT9tbNSvygR6B16wZ%2BbEVdQjw>