Date: Mon, 27 Aug 2018 12:33:25 +0300 From: Daniel Braniss <danny@cs.huji.ac.il> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: "freebsd-arm@freebsd.org" <arm@freebsd.org> Subject: Re: thermal DTS for allwinner/h3 Message-ID: <0897C7CF-D6D0-4E5C-A538-7A4F5502C30B@cs.huji.ac.il> In-Reply-To: <20180827094837.187596ce4421eae4b87b6f9f@bidouilliste.com> References: <23EA1292-4DF7-4C08-9EDA-C235CC461F1D@cs.huji.ac.il> <5E41E0AE-35B4-45AC-951E-705CAEADBFDA@cs.huji.ac.il> <20180827094837.187596ce4421eae4b87b6f9f@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 27 Aug 2018, at 10:48, Emmanuel Vadot <manu@bidouilliste.com> =
wrote:
>=20
>=20
> Hi Daniel,
>=20
> On Mon, 27 Aug 2018 08:43:51 +0300
> Daniel Braniss <danny@cs.huji.ac.il <mailto:danny@cs.huji.ac.il>> =
wrote:
>=20
>> iI hate spell checkers
>>=20
>>=20
>>> On 27 Aug 2018, at 08:40, Daniel Braniss <danny@cs.huji.ac.il =
<mailto:danny@cs.huji.ac.il>> wrote:
>>>=20
>>> hi,
>>> this overlay is working form me, though I think the actual =
temperature reported is a bit off (40-50C)
>=20
> Thanks,
>=20
> You miss the nvmem cell declaration in the sid node that's why the
> temperature is a bit of I guess. But anyway H3 is a really hot SoC, on
> a idle board without cpufreq support (so cpu clocked at 1008Mhz iirc)
> my IR thermometer reports ~40C
>=20
>>> /dts-v1/;
>>> /plugin/;
>>>=20
>>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> #include <dt-bindings/clock/sun8i-h3-ccu.h>
>>> #include <dt-bindings/reset/sun8i-h3-ccu.h>
>>>=20
>>> / {
>>> compatible =3D "allwinner,sun8i-h3";
>>> };
>>>=20
>>> &{/soc} {
>>> ths: thermal_sensor@1c25000 {
>>> compatible =3D "allwinner,sun8i-h3-ths";
>>> reg =3D <0x01c25000 0x100>;
>>> interrupts =3D <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
>>> clocks =3D <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
>>> clock-names =3D "apb", "ths";
>>> resets =3D <&ccu RST_BUS_THS>;
>>> reset-names =3D "apb";
>>> status =3D "okay";
>>> nvmem-cells =3D <&ths_calib>;
>>> nvmem-cell-names =3D "ths-calib";
>>> };
>>> };
>>>=20
>>>=20
>>> _______________________________________________
>>> freebsd-arm@freebsd.org mailing list
>>> https://lists.freebsd.org/mailman/listinfo/freebsd-arm
>>> To unsubscribe, send any mail to =
"freebsd-arm-unsubscribe@freebsd.org"
>>=20
>> _______________________________________________
>> freebsd-arm@freebsd.org <mailto:freebsd-arm@freebsd.org> mailing list
>> https://lists.freebsd.org/mailman/listinfo/freebsd-arm =
<https://lists.freebsd.org/mailman/listinfo/freebsd-arm>;
>> To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org =
<mailto:freebsd-arm-unsubscribe@freebsd.org>"
>=20
if you send me the missing bits I can test it.
danny
>=20
> --=20
> Emmanuel Vadot <manu@bidouilliste.com <mailto:manu@bidouilliste.com>> =
<manu@freebsd.org <mailto:manu@freebsd.org>>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0897C7CF-D6D0-4E5C-A538-7A4F5502C30B>