Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Feb 2019 22:29:12 +0000 (UTC)
From:      David Bright <dab@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r344644 - stable/12/sys/dev/pms/RefTisa/tisa/sassata/sas/ini
Message-ID:  <201902272229.x1RMTCMx069356@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dab
Date: Wed Feb 27 22:29:12 2019
New Revision: 344644
URL: https://svnweb.freebsd.org/changeset/base/344644

Log:
  MFC r344473:
  
  CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
  
  A pointer is first tested for NULL. If non-NULL, another pointer is
  set equal to the first. The second pointer is then checked for NULL
  and an error path taken if so. This second test and the associated
  path is dead code as the pointer value, having just been checked for
  NULL, cannot be NULL at this point. Remove the dead code.
  
  Sponsored by:	Dell EMC Isilon

Modified:
  stable/12/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c
==============================================================================
--- stable/12/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c	Wed Feb 27 22:26:18 2019	(r344643)
+++ stable/12/sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c	Wed Feb 27 22:29:12 2019	(r344644)
@@ -1820,12 +1820,6 @@ tiNumOfLunIOCTLreq(
       break;
     }
     tdIORequestBody = (tdIORequestBody_t *)tiRequestBody;
-    
-    if(tdIORequestBody == agNULL)
-    {
-      status = IOCTL_CALL_FAIL;
-      break;
-    }
     tdIORequestBody->tiIORequest = tiIORequest;
     
     /* save context if we need to abort later */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902272229.x1RMTCMx069356>