Date: Fri, 17 Jan 2020 22:26:41 +0000 (UTC) From: Ben Woods <woodsb02@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356855 - head/usr.sbin/bsdinstall/partedit Message-ID: <202001172226.00HMQfix049947@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: woodsb02 (ports committer) Date: Fri Jan 17 22:26:41 2020 New Revision: 356855 URL: https://svnweb.freebsd.org/changeset/base/356855 Log: Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR This resulted in the partitioning step failing if either of the "Auto (UFS)" or "Manual" options were selected. Reason: partedit was attempting to open a directory (TMPDIR) read/write, which resulted in errno(2) 21 - EISDIR - Is a directory. Reported by: Clay Daniels <clay.daniels.jr@gmail.com> Reviewed by: Ryan Moeller <ryan@freqlabs.com> Approved by: emaste, bcran Differential Revision: https://reviews.freebsd.org/D23232 Modified: head/usr.sbin/bsdinstall/partedit/partedit.c Modified: head/usr.sbin/bsdinstall/partedit/partedit.c ============================================================================== --- head/usr.sbin/bsdinstall/partedit/partedit.c Fri Jan 17 22:24:56 2020 (r356854) +++ head/usr.sbin/bsdinstall/partedit/partedit.c Fri Jan 17 22:26:41 2020 (r356855) @@ -93,7 +93,7 @@ main(int argc, const char **argv) tmpdir = getenv("TMPDIR"); if (tmpdir == NULL) tmpdir = "/tmp"; - tmpdfd = open(tmpdir, O_RDWR | O_DIRECTORY); + tmpdfd = open(tmpdir, O_DIRECTORY); if (tmpdfd < 0) err(EX_OSERR, "%s", tmpdir); unlinkat(tmpdfd, "bsdinstall-esps", 0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001172226.00HMQfix049947>