Date: Sun, 1 Dec 2013 22:23:29 -0500 From: Eitan Adler <eadler@freebsd.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: Konstantin Belousov <kostikbel@gmail.com>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r258779 - in head/sys/dev: cesa drm drm2/i915 drm2/radeon hatm Message-ID: <CAF6rxgk=2Q%2B30_fEA3__mX1DLHpUTJSrL=N%2Brn8NLXNDYUQpKA@mail.gmail.com> In-Reply-To: <20131201230735.GB24849@stack.nl> References: <201311302216.rAUMGcPA037268@svn.freebsd.org> <20131201075944.GF59496@kib.kiev.ua> <20131201230735.GB24849@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Dec 1, 2013 at 6:07 PM, Jilles Tjoelker <jilles@stack.nl> wrote: >> Revert the drm2/i915 changes from this and following commits now. >> You did not contacted obvious maintainer of the file. Of course I did not. This was discussed on arch@ and the change made mechanically. >> The changes are pointless and make the import of upstream changes >> harder; for i915_reg.h, much harder. > > This is a valid concern. The change should be submitted to upstream; if > upstream does not want the change, it is better to avoid the issue by > adding -fno-strict-overflow for the offending files, matching upstream. I will revert to the broken and incorrect code in sys/dev/drm2/i915. Upstream should be contacted with the patch. >> Not to mention that the whole churn is not needed if the >> -fno-strict-overflow flag is used. > > I think the undefined shifts should be fixed where possible and not in > contributed code. Agreed. In addition, contributed code ought to be clearly differentiated in the directory hierarchy. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgk=2Q%2B30_fEA3__mX1DLHpUTJSrL=N%2Brn8NLXNDYUQpKA>