Date: Mon, 30 Jul 2001 04:28:39 +0100 (BST) From: George Reid <greid@FreeBSD.org> To: Patrick Li <pat@databits.net> Cc: <freebsd-ports@FreeBSD.org> Subject: Re: ports/29310: Fix bento checksum errors Message-ID: <20010730042447.B11207-100000@sobek.lan> In-Reply-To: <Pine.BSF.4.21.0107292309340.17610-100000@hex.databits.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 29 Jul 2001, Patrick Li wrote: > without testing. I dont know what the author changed. You need to find out before you send-pr. > If its just checksum update because of some change > without new version of program released, then just > PORTREVISION bump + checksum update should be it. Key word: If. You didn't bother to check. How do you know that somebody hasn't replaced the tarball with some kind of trojan? You need to generate and read diffs against the two tarballs. > Thats what i see happen most of the time and people just > put chase checksum in commit message. Yes, and 99% of the time somebody will complain if the differences aren't summarised. A short sentence explaining the differences is sufficient, for example: "No changes, tarball rerolled", "Author's email address changed in all files", "GNU public license added to tarball", "Small typo fixed in Makefile". -- +-------------------+---------------------+ | George Reid | FreeBSD Committer | | +44 7740 197460 | greid@FreeBSD.org | +-------------------+---------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010730042447.B11207-100000>