Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Oct 2019 12:05:22 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Brooks Davis <brooks@freebsd.org>, Warner Losh <imp@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r353639 - head/share/mk
Message-ID:  <32ca31df-3039-0f0c-1006-86bd67d1e9e4@FreeBSD.org>
In-Reply-To: <20191016171811.GA52641@spindle.one-eyed-alien.net>
References:  <201910161320.x9GDKaBK021462@repo.freebsd.org> <20191016171811.GA52641@spindle.one-eyed-alien.net>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--HJohtPujDkhS49pXwHMaTYz5Uyjxeb526
Content-Type: multipart/mixed; boundary="JDXklkezbv4kEuJW2zklDnqfHTFRoK0L7";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Brooks Davis <brooks@freebsd.org>, Warner Losh <imp@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Message-ID: <32ca31df-3039-0f0c-1006-86bd67d1e9e4@FreeBSD.org>
Subject: Re: svn commit: r353639 - head/share/mk
References: <201910161320.x9GDKaBK021462@repo.freebsd.org>
 <20191016171811.GA52641@spindle.one-eyed-alien.net>
In-Reply-To: <20191016171811.GA52641@spindle.one-eyed-alien.net>

--JDXklkezbv4kEuJW2zklDnqfHTFRoK0L7
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 10/16/2019 10:18 AM, Brooks Davis wrote:
> On Wed, Oct 16, 2019 at 01:20:36PM +0000, Warner Losh wrote:
>> Author: imp
>> Date: Wed Oct 16 13:20:36 2019
>> New Revision: 353639
>> URL: https://svnweb.freebsd.org/changeset/base/353639
>>
>> Log:
>>   bsd.compat.mk isn't setup to be included outside of Makefile.inc so =
comment it
>>   out here until that's sorted out. Otherwise the build is broken. whe=
n
>>   TARGET_ARCH isn't defined.
>=20
> Thanks for committing this workaround.  I forgot to test bare builds (n=
ot
> buildworld/buildenv/...) because I almost always cross build (either fo=
r a
> different arch or targeting CURRENT from STABLE).
>=20
> I'm currently testing a switch from TARGET_ARCH to MACHINE_ARCH and
> TARGET_CPUTYPE to CPUTYPE.
>=20
> -- Brooks
>=20

As a hack you could do
=2Eif defined(SRCTOP)
=2Einclude <bsd.compat.mk>
=2Eendif

Or rename it src.compat.mk and remove from Makefile and do
=2Esinclude <src.compat.mk>

--=20
Regards,
Bryan Drewery


--JDXklkezbv4kEuJW2zklDnqfHTFRoK0L7--

--HJohtPujDkhS49pXwHMaTYz5Uyjxeb526
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl2nafJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5
MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G
l88zMQgAzk/s3Nn3y6ABtA6Dq4WxRbmXpkD9ro76iPV1Pp+ImPXCgd+oleTgPLeQ
XhTiyEf61Pbht/GZjfmMvcrUr/uLuwEfZQz2hZ7WZ6LAIEtLZRfX0OMuA3Nbunht
pqbZW7p8+ycWMUmKksL2OSnBnLsKLkqAZlUWPVbWfqQX4dIlSdPai5hLbpNnyxoT
lUyrFdDtJsYTXauOXS6pCc6gKBSR7WKyNy7euhtA8mewKS6DzUzEVRVcvq4xM4dA
qTh85rxwCrMLOUyCOFkLvMcUoPVh8AhJUlg5wYWlzYnUp9yi5z2pp1TzZEXzPAEt
z7bBJkEljbzEKsFlRTBHyGxjMSOZTw==
=Gb2T
-----END PGP SIGNATURE-----

--HJohtPujDkhS49pXwHMaTYz5Uyjxeb526--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32ca31df-3039-0f0c-1006-86bd67d1e9e4>