Date: Fri, 11 Apr 2003 16:20:06 -0700 (PDT) From: Adam Weinberger <adamw@freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/50840: mail/squirrelmail - Port Docs in wrong location Message-ID: <200304112320.h3BNK6Pa065296@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/50840; it has been noted by GNATS.
From: Adam Weinberger <adamw@freebsd.org>
To: "Scot W. Hetzel" <hetzels@westbend.net>
Cc: FreeBSD-gnats-submit@freebsd.org, simond@irrelevant.org
Subject: Re: ports/50840: mail/squirrelmail - Port Docs in wrong location
Date: Fri, 11 Apr 2003 16:20:08 -0700
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
>> (04.11.2003 @ 1558 PST): Scot W. Hetzel said, in 67K: <<
> +PLIST_SUB+= PORTVERSION=${PORTVERSION}
> +
> +DOCS= AUTHORS COPYING ChangeLog INSTALL README ReleaseNotes-${PORTVERSION} UPGRADE
> +
> +post-extract:
> + @${MV} ${WRKSRC}/ReleaseNotes ${WRKSRC}/ReleaseNotes-${PORTVERSION}
Why are you doing this? Why do you want to alter the build mechanism to
make a PORTVERSION-specific Relnotes file, if it just gets deleted on
upgrade anyway?
You're altering what the author intended. If you'd like to see
ReleaseNotes renamed, please contact the author.
> +
> pre-install:
> @${ECHO} "Your umask should be lax while installing this. Like, 022 or something."
> @${SH} pkg-install ${PKGNAME} PRE-INSTALL
>
> do-install:
> - ${MKDIR} ${PREFIX}/squirrelmail
> - ${CP} -R ${WRKSRC}/* ${PREFIX}/squirrelmail
> - ${CHOWN} -R www:www ${PREFIX}/squirrelmail/data
> + ${MKDIR} -p ${PREFIX}/www/squirrelmail
> + ${CP} -R ${WRKSRC}/* ${PREFIX}/www/squirrelmail
> +.for file in ${DOCS}
> + @${RM} ${PREFIX}/www/squirrelmail/${file}
> +.endfor
> + @${RM} -rf ${PREFIX}/www/squirrelmail/doc
> + ${CHOWN} -R www:www ${PREFIX}/www/squirrelmail/data
> +.if !defined(NOPORTDOCS)
> + @${MKDIR} ${DOCSDIR}
> +.for file in ${DOCS}
> + @${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
> +.endfor
> + ${CP} -R ${WRKSRC}/doc/* ${DOCSDIR}
> +.endif
So you're suggesting that:
(1) The same files get installed anyway.
(2) Then the doc files are deleted.
(3) Then the entire doc/ directory is deleted
(4) Then they're conditionally added back in
This makes assumptions about that people haven't put into their
squirrelmail directory.
I'd personally rather see a list of files to install generated
dynamically within the Makefile by listing ${WRKSRC} and then :S'ing out
the doc/ directory from that list.
Also, I disagree that this should automatically go under /usr/local/www.
I'm interested in hearing the maintainer's thoughts.
# Adam
>> end of "ports/50840: mail/squirrelmail - Port Docs in wrong location" from Scot W. Hetzel <<
- --
Adam Weinberger
vectors.cx >> adam@vectors.cx
FreeBSD.org << adamw@FreeBSD.ORG
#vim:set ts=8: 8-char tabs prevent tooth decay.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+l02oo8KM2ULHQ/0RAoDFAJ0Uhu8hOKtt00VB9fOKouTAxWymlgCgm5fo
qEUEue/NeYpA7YhIer/n1FY=
=Xph6
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200304112320.h3BNK6Pa065296>