Date: Fri, 16 Mar 2007 12:19:04 +0000 From: Ceri Davies <ceri@submonkey.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libufs type.c Message-ID: <20070316121904.GB53780@submonkey.net> In-Reply-To: <20070316115157.GA6440@garage.freebsd.pl> References: <200703160313.l2G3DTHP048236@repoman.freebsd.org> <20070316111612.GZ53780@submonkey.net> <20070316115157.GA6440@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--ugMgaRwDDWDxqvmW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 16, 2007 at 12:51:57PM +0100, Pawel Jakub Dawidek wrote: > On Fri, Mar 16, 2007 at 11:16:12AM +0000, Ceri Davies wrote: > > On Fri, Mar 16, 2007 at 03:13:29AM +0000, Pawel Jakub Dawidek wrote: > > > pjd 2007-03-16 03:13:29 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > lib/libufs type.c=20 > > > Log: > > > The ufs_disk_fillout(3) can take special device name (with or witho= ut /dev/ > > > prefix) as an argument and mount point path. At the end it has to f= ind > > > device name file system is stored on, which means when mount point = path is > > > given, it tries to look into /etc/fstab and find special device > > > corresponding to the given mount point. This is not perfect, becaus= e it > > > doesn't handle the case when file system is mounted by hand and mou= nt point > > > is given as an argument. > > > =20 > > > I found this problem while trying to use snapinfo(8), which passes = mount > > > points to the ufs_disk_fillout(3) function, but I had file system m= ounted > > > manually, so snapinfo(8) was exiting with the error below: > > > =20 > > > ufs_disk_fillout: No such file or directory > > > =20 > > > I modified libufs(3) to handle those arguments (the order is import= ant): > > > =20 > > > 1. special device with /dev/ prefix > > > 2. special device without /dev/ prefix > > > 3. mount point listed in /etc/fstab, directory exists > > > 4. mount point listed in /etc/fstab, directory doesn't exist > > > 5. mount point of a file system mounted by hand > >=20 > > Is there any chance that this, or the related snapinfo commit, fixes > > PR 94635? >=20 > I'm quite sure this should be fixed now, yes. Can we ask submitter to > retest? Well that's me, so will do :) Thanks, Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --ugMgaRwDDWDxqvmW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF+os4ocfcwTS3JF8RAthhAKCIhCZElXxmjHAMxWPr4e9Z5+LoGACdF4SU BCrZxKLpLL7b+5VjJcr67PA= =7yDs -----END PGP SIGNATURE----- --ugMgaRwDDWDxqvmW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070316121904.GB53780>