Date: Sun, 23 Jul 2000 06:30:06 -0700 From: Alfred Perlstein <bright@wintelcom.net> To: Mike Smith <msmith@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern imgact_elf.c Message-ID: <20000723063005.L13979@fw.wintelcom.net> In-Reply-To: <20000723062802.K13979@fw.wintelcom.net>; from bright@wintelcom.net on Sun, Jul 23, 2000 at 06:28:02AM -0700 References: <20000723005214.J13979@fw.wintelcom.net> <200007230811.BAA13280@mass.osd.bsdi.com> <20000723062802.K13979@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
* Alfred Perlstein <bright@wintelcom.net> [000723 06:28] wrote: > * Mike Smith <msmith@FreeBSD.org> [000723 01:01] wrote: > > > I'm also concerned that you're using atomic_set_long() rather than > > > or'ing the flag in, there doesn't seem to be a flag in vnode.h that > > > could possibly co-exist with VTEXT but clearing all other flags > > > introduces an unexpected side-effect. > > > > Er, atomic_set_long is a bit-set operation. > > It's still overly paranoid. And yet another place where we've used bad function names to describe something. (would atomic_or_long have been so hard?) -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000723063005.L13979>