Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Mar 2012 09:24:47 -0700
From:      Jason Helfman <jgh@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        dkg@fifthhorseman.net
Subject:   ports/166092: [PATCH] security/monkeysphere: drop unknown post-deinstall target, use standard deinstall script, tighten plist
Message-ID:  <1331742287.431310.79307.nullmailer@experts-exchange.com>
Resent-Message-ID: <201203141630.q2EGU1K3068880@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         166092
>Category:       ports
>Synopsis:       [PATCH] security/monkeysphere: drop unknown post-deinstall target, use standard deinstall script, tighten plist
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 14 16:30:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jason Helfman
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
post-deinstall is an invalid target, use pkg-deinstall script.
respect DOCSDIR and DATADIR in plist

Port maintainer (dkg@fifthhorseman.net) is cc'd.

Generated with FreeBSD Port Tools 0.99_4 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:

--- monkeysphere-0.24_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/security/monkeysphere/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	22 Sep 2010 05:21:28 -0000	1.2
+++ Makefile	14 Mar 2012 16:24:36 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	monkeysphere
 PORTVERSION=	0.24
+PORTREVISION=	1
 CATEGORIES=	security
 MASTER_SITES=	http://archive.monkeysphere.info/debian/pool/monkeysphere/m/monkeysphere/
 # hack for debian orig tarballs
@@ -69,7 +70,4 @@
 	@${SETENV} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 .endif
 
-post-deinstall:
-	@${SETENV} ${SH} ${PKGDEINSTALL} ${PKGNAME} POST-DEINSTALL
-
 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/security/monkeysphere/pkg-plist,v
retrieving revision 1.1
diff -u -r1.1 pkg-plist
--- pkg-plist	10 Mar 2009 07:45:26 -0000	1.1
+++ pkg-plist	14 Mar 2012 16:24:36 -0000
@@ -1,36 +1,36 @@
 sbin/monkeysphere-host
 sbin/monkeysphere-authentication
-share/doc/monkeysphere/TODO
-share/doc/monkeysphere/MonkeySpec
-share/doc/monkeysphere/getting-started-user.mdwn
-share/doc/monkeysphere/getting-started-admin.mdwn
+%%DOCSDIR%%/TODO
+%%DOCSDIR%%/MonkeySpec
+%%DOCSDIR%%/getting-started-user.mdwn
+%%DOCSDIR%%/getting-started-admin.mdwn
 bin/openpgp2ssh
 bin/pem2openpgp
 bin/monkeysphere
-share/monkeysphere/mh/publish_key
-share/monkeysphere/mh/import_key
-share/monkeysphere/mh/set_expire
-share/monkeysphere/mh/diagnostics
-share/monkeysphere/mh/add_hostname
-share/monkeysphere/mh/add_revoker
-share/monkeysphere/mh/revoke_hostname
-share/monkeysphere/mh/revoke_key
-share/monkeysphere/keytrans
-share/monkeysphere/defaultenv
-share/monkeysphere/VERSION
-share/monkeysphere/transitions/0.23
-share/monkeysphere/transitions/README.txt
-share/monkeysphere/ma/list_certifiers
-share/monkeysphere/ma/add_certifier
-share/monkeysphere/ma/update_users
-share/monkeysphere/ma/setup
-share/monkeysphere/ma/remove_certifier
-share/monkeysphere/ma/diagnostics
-share/monkeysphere/common
-share/monkeysphere/m/gen_subkey
-share/monkeysphere/m/ssh_proxycommand
-share/monkeysphere/m/subkey_to_ssh_agent
-share/monkeysphere/m/import_subkey
+%%DATADIR%%/mh/publish_key
+%%DATADIR%%/mh/import_key
+%%DATADIR%%/mh/set_expire
+%%DATADIR%%/mh/diagnostics
+%%DATADIR%%/mh/add_hostname
+%%DATADIR%%/mh/add_revoker
+%%DATADIR%%/mh/revoke_hostname
+%%DATADIR%%/mh/revoke_key
+%%DATADIR%%/keytrans
+%%DATADIR%%/defaultenv
+%%DATADIR%%/VERSION
+%%DATADIR%%/transitions/0.23
+%%DATADIR%%/transitions/README.txt
+%%DATADIR%%/ma/list_certifiers
+%%DATADIR%%/ma/add_certifier
+%%DATADIR%%/ma/update_users
+%%DATADIR%%/ma/setup
+%%DATADIR%%/ma/remove_certifier
+%%DATADIR%%/ma/diagnostics
+%%DATADIR%%/common
+%%DATADIR%%/m/gen_subkey
+%%DATADIR%%/m/ssh_proxycommand
+%%DATADIR%%/m/subkey_to_ssh_agent
+%%DATADIR%%/m/import_subkey
 @unexec if cmp -s %D/etc/monkeysphere/monkeysphere.conf.sample %D/etc/monkeysphere/monkeysphere.conf; then rm -f %D/etc/monkeysphere/monkeysphere.conf; fi
 etc/monkeysphere/monkeysphere.conf.sample
 @exec if [ ! -f %D/etc/monkeysphere/monkeysphere.conf ] ; then cp -p %D/%F %B/monkeysphere.conf; fi
@@ -40,10 +40,10 @@
 @unexec if cmp -s %D/etc/monkeysphere/monkeysphere-authentication.conf.sample %D/etc/monkeysphere/monkeysphere-authentication.conf; then rm -f %D/etc/monkeysphere/monkeysphere-authentication.conf; fi
 etc/monkeysphere/monkeysphere-authentication.conf.sample
 @exec if [ ! -f %D/etc/monkeysphere/monkeysphere-authentication.conf ] ; then cp -p %D/%F %B/monkeysphere-authentication.conf; fi
-@dirrm share/doc/monkeysphere
-@dirrm share/monkeysphere/transitions
-@dirrm share/monkeysphere/mh
-@dirrm share/monkeysphere/ma
-@dirrm share/monkeysphere/m
-@dirrm share/monkeysphere
+@dirrm %%DOCSDIR%%
+@dirrm %%DATADIR%%/transitions
+@dirrm %%DATADIR%%/mh
+@dirrm %%DATADIR%%/ma
+@dirrm %%DATADIR%%/m
+@dirrm %%DATADIR%%
 @dirrm etc/monkeysphere
--- monkeysphere-0.24_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1331742287.431310.79307.nullmailer>