Date: Tue, 8 Jan 2019 10:23:05 -0700 From: Sean Bruno <sbruno@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest Message-ID: <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org> In-Reply-To: <20190103232315.GA10712@urd.tobik.me> References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD Content-Type: multipart/mixed; boundary="1xRTm9mB04oZGDNf2NAQlskitXBnPWH9M"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org> Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> In-Reply-To: <20190103232315.GA10712@urd.tobik.me> --1xRTm9mB04oZGDNf2NAQlskitXBnPWH9M Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 1/3/19 4:23 PM, Tobias Kortkamp wrote: >> >> On 1/3/19 2:54 PM, Tobias Kortkamp wrote: >>>> +USE_QT=3D buildtools \ >>> Does clementine-player, a music player, really need qt5-buildtools >>> at runtime or should this be buildtools_build instead? >>> >>>> + concurrent \ >>>> + core \ >>>> dbus \ >>>> gui \ >>>> imageformats \ >>>> - qmake_build \ >>>> linguist_build \ >>>> - moc_build \ >>>> network \ >>>> opengl \ >>>> - qtestlib \ >>>> - rcc_build \ >>>> + qmake_build \ >>>> + testlib \ >>> Same here. Does it really need qt5-testlib at runtime? >>> >> Probably not? >> >> sean >> > So I guess they are not needed at runtime. Will you change them > to build dependencies? Yeah, I'll look at it today. Thanks! sean --1xRTm9mB04oZGDNf2NAQlskitXBnPWH9M-- --kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlw03HlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LYU+wf+KTgMZ/MCIhzjo1ssV3cS/iIs8bXzilAbG8QRWp1vEAwLSXnK8AO4cjKY WQ6qwzn/4yva0KKGt7kHKdkX3ooRGDBmuWf3KwvB+Q+4+vdTj0ZiPHSCRbWTzVlY nL7Zpyri1YbTtkNZKe0izmVq6pSE/T4ksJBK6b6Qrfn7vfKlGNBXfapSe2HeMt3T w7lfenOpy71/HgRSECCNjmc2TBY47D5IyrbBJHz/3NggiVKwT6+P55Or2SJTg+qU CMSjSEqw8FwQEiioFnxaSVRrWj294hpectDsXShhqpW7PKdR+/YiU2L2m5mSQRtD NiXBJlzGIaGrvH0ITdfwAg2yS+5/Bg== =L4ek -----END PGP SIGNATURE----- --kmwYskeMvL8rYGqpg5gtXXloRd1cY91hD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b472df4d-574e-09f8-6212-687209d31bbc>