Date: Sat, 15 Dec 2001 17:53:49 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: Luigi Rizzo <rizzo@aciri.org>, Mark Murray <mark@grondar.za> Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Are prototypes for main() illegal by any standard ? (was Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <p05101000b841833d4238@[128.113.24.47]> In-Reply-To: <20011214102915.L49775@iguana.aciri.org> References: <20011214094310.A25238@dragon.nuxi.com> <200112141803.fBEI3MU02957@grimreaper.grondar.org> <20011214102915.L49775@iguana.aciri.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 10:29 AM -0800 12/14/01, Luigi Rizzo wrote: >Anyways, i think we should not make a big deal out of this. > >Is it illegal, by any standard, to supply prototypes for main() ? > >If not, what is wrong in casually adding them whenever you happen >to touch those files ? Personally, I think your commit was fine. I can see someone being unhappy if you emailed *them* and told *them* to add a prototype for main(), but I personally don't see what's wrong with you adding the prototype if you feel like doing it. As near as I can see, the argument against your change boils down to "we changed gcc in -current so you should not need to add a prototype to avoid these warnings in -current". I do not find that to be a convincing reason to back out the change. There are more C compilers in the world than the gcc we happen to have in -current right now, and if adding the prototype does not *break* anything then I see no reason for anyone to feel bad if someone else feels like adding it. If adding the prototype for main() does *break* something, then it would be helpful to find out what it is that breaks. -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05101000b841833d4238>