Date: Tue, 16 Jul 2013 07:26:47 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r253380 - head/lib/libc/stdlib Message-ID: <201307160726.r6G7QlwE045679@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: avg Date: Tue Jul 16 07:26:46 2013 New Revision: 253380 URL: http://svnweb.freebsd.org/changeset/base/253380 Log: libc: name passed into __setenv is not necessarily NUL-terminated That's particularly true when __setenv is called from __merge_environ. MFC after: 4 days Modified: head/lib/libc/stdlib/getenv.c Modified: head/lib/libc/stdlib/getenv.c ============================================================================== --- head/lib/libc/stdlib/getenv.c Tue Jul 16 06:50:22 2013 (r253379) +++ head/lib/libc/stdlib/getenv.c Tue Jul 16 07:26:46 2013 (r253380) @@ -505,7 +505,7 @@ __setenv(const char *name, size_t nameLe envVars[envNdx].valueSize = valueLen; /* Save name of name/value pair. */ - env = stpcpy(envVars[envNdx].name, name); + env = stpncpy(envVars[envNdx].name, name, nameLen); if ((envVars[envNdx].name)[nameLen] != '=') env = stpcpy(env, "="); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307160726.r6G7QlwE045679>