Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Oct 2012 13:00:41 +0100
From:      Andre Oppermann <andre@freebsd.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, svn-src-user@FreeBSD.org
Subject:   Re: svn commit: r242355 - user/andre/tcp_workqueue/sys/sys
Message-ID:  <508FC169.9050208@freebsd.org>
In-Reply-To: <20121030114413.GC70741@FreeBSD.org>
References:  <201210301133.q9UBXlke080637@svn.freebsd.org> <20121030114413.GC70741@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 30.10.2012 12:44, Gleb Smirnoff wrote:
> On Tue, Oct 30, 2012 at 11:33:47AM +0000, Andre Oppermann wrote:
> A> Author: andre
> A> Date: Tue Oct 30 11:33:47 2012
> A> New Revision: 242355
> A> URL: http://svn.freebsd.org/changeset/base/242355
> A>
> A> Log:
> A>   Add define for CSUM_UFO which is UDP checksum offload.
> A>   Spell out TSO as TCP segmentation offload.
> A>
> A> Modified:
> A>   user/andre/tcp_workqueue/sys/sys/mbuf.h
> A>
> A> Modified: user/andre/tcp_workqueue/sys/sys/mbuf.h
> A> ==============================================================================
> A> --- user/andre/tcp_workqueue/sys/sys/mbuf.h	Tue Oct 30 11:15:36 2012	(r242354)
> A> +++ user/andre/tcp_workqueue/sys/sys/mbuf.h	Tue Oct 30 11:33:47 2012	(r242355)
> A> @@ -280,8 +280,8 @@ struct mbuf {
> A>  #define	CSUM_TCP		0x0002		/* will csum TCP */
> A>  #define	CSUM_UDP		0x0004		/* will csum UDP */
> A>  #define	CSUM_IPFRAG		0x0008		/* IP fragmentation offload */
> A> -/*				0x0010		*/
> A> -#define	CSUM_TSO		0x0020		/* will do TSO */
> A> +#define	CSUM_UFO		0x0010		/* UDP fragmentation offload */
>
> So does it mean fragmentation as in comment or checksum as in commit log?

Fragmentation as in comment.  Commit message is wrong.

> A> +#define	CSUM_TSO		0x0020		/* TCP segmentation offliad */
>
> Typo in last word in comment.

Oops.  Thanks.

> A>  #define	CSUM_SCTP		0x0040		/* will csum SCTP */
> A>  #define CSUM_SCTP_IPV6		0x0080		/* will csum IPv6/SCTP */
> A>

-- 
Andre




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?508FC169.9050208>