Date: Thu, 09 Apr 2015 08:06:43 +0200 From: John Marino <freebsd.contact@marino.st> To: Bryan Drewery <bdrewery@FreeBSD.org>, Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r383191 - head/Mk Message-ID: <552616F3.9080500@marino.st> In-Reply-To: <5525D48E.5090305@FreeBSD.org> References: <201504040535.t345ZJ9M028396@svn.freebsd.org> <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/9/2015 03:23, Bryan Drewery wrote: > On 4/8/2015 6:21 PM, Dmitry Marakasov wrote: >> * Bryan Drewery (bdrewery@FreeBSD.org) wrote: >> >>>>> Re-enable and rework check added in r370464 to validate the first CATEGORY >>>>> is set properly. The problem causing the revert in r370475 was fixed in >>>>> r383190. >>>>> >>>>> With hat: portmgr >>>> >>>> This breaks countless usecases when port is build which does not belong >>>> to the ports tree. >>> >>> Please name even 1 case. >> >> I have a lot of WIP ports in flat directory. Tons of custom port >> repositories on github with flat structure. > > Short of more details, that does not sound like a supported setup. > > I can't read your mind. Please give me a specific case or I can't help. Since it's obviously a custom tree, he could always just patch this check out. I'd be surprised if no other Mk file was patched already. >>>> Afaik, we have that information in ports - based on >>>> that PORTSDIR is chosen. The same mechanism should be used here to >>>> conditionally enable the check. >>> >>> That made no sense. >> >> Explain. >> > > I do not understand what you are trying to say. It makes no sense. He's saying the check should be conditional based on PORTSDIR, but this sounds wrong to me. What about /usr/dports? What about somebody that intentionally installs ports somewhere other than /usr/ports ? He should be using reviews.freebsd.org for code suggestions so we can see the implementation. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?552616F3.9080500>