Date: Fri, 24 May 2002 12:18:53 -0700 From: Peter Wemm <peter@wemm.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.kern.mk Message-ID: <20020524191853.4A9583807@overcee.wemm.org> In-Reply-To: <20020524223514.E3592-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote:
> On Thu, 23 May 2002, Peter Wemm wrote:
>
> > peter 2002/05/23 18:02:45 PDT
> >
> > Modified files:
> > share/mk bsd.kern.mk
> > Log:
> > For now, make the .ifdef GCC3 case default. We should change -Wno-format
> > back to -fformat-extensions (or whatever) when we have the functionality.
> > We are gaining warnings again that should be fixed but the are being hidd
en
> > by NO_WERROR and all the -Wformat noise.
>
> We gained this functionality a few days ago. I have been running with the
> GCC3 case by default but hoped to remove it (there might be a problem with
> using gcc3 from ports).
Actually, we do not quite have it yet:
if_an.c:444
printf("an%d: Ethernet address: %6D\n", sc->an_unit,
sc->arpcom.ac_enaddr, ":");
yields:
../../../dev/an/if_an.c: In function `an_attach':
../../../dev/an/if_an.c:444: warning: too many arguments for format
and so on. There is something wrong with the rev 1.3 gcc c-format.c patch.
In the comments:
+ The format %D provides a hexdump given a pointer and separator string:
+ ("%6D", ptr, ":") -> XX:XX:XX:XX:XX:XX
+ ("%*D", len, ptr, " ") -> XX XX XX XX ...
%b seems ok, although:
../../../kern/tty_pty.c: In function `ptyinit':
../../../kern/tty_pty.c:158: warning: use of `' length modifier with `r' type character
../../../kern/tty_pty.c: In function `pty_clone':
../../../kern/tty_pty.c:860: warning: use of `' length modifier with `r' type character
The code in question is:
pt->devs = devs = make_dev(&pts_cdevsw, n,
UID_ROOT, GID_WHEEL, 0666, "tty%c%r", names[n / 32], n % 32);
It looks like it has started requiring an explicit length modifier now?
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020524191853.4A9583807>