Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Apr 2016 05:10:31 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r298035 - head/sys/cam/ata
Message-ID:  <201604150510.u3F5AVVX083724@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Fri Apr 15 05:10:31 2016
New Revision: 298035
URL: https://svnweb.freebsd.org/changeset/base/298035

Log:
  Out of an abundance of caution treat
   * Samsung 843T Series SSDs (MZ7WD*)
   * Samsung PM851 Series SSDs (MZ7TE*)
   * Samsung PM853T Series SSDs (MZ7GE*)
  as known having broken NCQ TRIM support as they appear to be based on
  the same controller technology as the 840 and 850 series.
  
  I've had at least one report of the PM853 being broken, so err on the
  side of caution for the above drives. The PM863/SM863 appears to be
  based on a newer controller, so give it the benefit of the doubt.

Modified:
  head/sys/cam/ata/ata_da.c

Modified: head/sys/cam/ata/ata_da.c
==============================================================================
--- head/sys/cam/ata/ata_da.c	Fri Apr 15 04:45:37 2016	(r298034)
+++ head/sys/cam/ata/ata_da.c	Fri Apr 15 05:10:31 2016	(r298035)
@@ -569,14 +569,22 @@ static struct ada_quirk_entry ada_quirk_
 	},
 	{
 		/*
+		 * Samsung SM863 Series SSDs (MZ7KM*)
+		 * 4k optimised, NCQ believed to be working
+		 */
+		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "SAMSUNG MZ7KM*", "*" },
+		/*quirks*/ADA_Q_4K
+	},
+	{
+		/*
 		 * Samsung 843T Series SSDs (MZ7WD*)
 		 * Samsung PM851 Series SSDs (MZ7TE*)
 		 * Samsung PM853T Series SSDs (MZ7GE*)
-		 * Samsung SM863 Series SSDs (MZ7KM*)
-		 * 4k optimised, NCQ Trim believed working
+		 * 4k optimised, NCQ believed to be broken since these are
+		 * appear to be built with the same controllers as the 840/850.
 		 */
 		{ T_DIRECT, SIP_MEDIA_FIXED, "*", "SAMSUNG MZ7*", "*" },
-		/*quirks*/ADA_Q_4K
+		/*quirks*/ADA_Q_4K | ADA_Q_NCQ_TRIM_BROKEN
 	},
 	{
 		/*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604150510.u3F5AVVX083724>