Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Feb 2017 05:25:29 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r432970 - head/audio/mixxx/files
Message-ID:  <201702010525.v115PT8T086823@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jbeich
Date: Wed Feb  1 05:25:29 2017
New Revision: 432970
URL: https://svnweb.freebsd.org/changeset/ports/432970

Log:
  audio/mixxx: unbreak with clang 4.0
  
  src/widget/wdisplay.cpp:89:19: error: ordered comparison between pointer and zero ('QPixmap **' and 'int')
      if (m_pPixmaps>0)
          ~~~~~~~~~~^~
  
  PR:		216354
  Reported by:	antoine (via exp-run)
  Submitted by:	tcberner

Added:
  head/audio/mixxx/files/patch-src_widget_wdisplay.cpp   (contents, props changed)

Added: head/audio/mixxx/files/patch-src_widget_wdisplay.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/audio/mixxx/files/patch-src_widget_wdisplay.cpp	Wed Feb  1 05:25:29 2017	(r432970)
@@ -0,0 +1,13 @@
+Fix bogus pointer comparison.
+
+--- src/widget/wdisplay.cpp.orig	2013-05-08 23:20:26 UTC
++++ src/widget/wdisplay.cpp
+@@ -86,7 +86,7 @@ void WDisplay::setPixmap(int iPos, const
+ 
+ void WDisplay::paintEvent(QPaintEvent *)
+ {
+-    if (m_pPixmaps>0)
++    if (m_pPixmaps)
+     {
+         int idx = (int)(m_fValue*(float)(m_iNoPos)/128.);
+         // Range check



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702010525.v115PT8T086823>