Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Feb 2017 19:23:03 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r314307 - head/sys/cam/ctl
Message-ID:  <201702261923.v1QJN3MJ065228@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Sun Feb 26 19:23:03 2017
New Revision: 314307
URL: https://svnweb.freebsd.org/changeset/base/314307

Log:
  Add support for SIMs without autosense.
  
  If we asked to send sense data by setting CAM_SEND_SENSE, but SIM didn't
  confirm transmission by setting CAM_SENT_SENSE, assume it was not sent.
  Queue the I/O back to CTL for later REQUEST SENSE with ctl_queue_sense().
  This is needed for error reporting on SPI HBAs like ahc(4)/ahd(4).
  
  MFC after:	2 weeks

Modified:
  head/sys/cam/ctl/scsi_ctl.c

Modified: head/sys/cam/ctl/scsi_ctl.c
==============================================================================
--- head/sys/cam/ctl/scsi_ctl.c	Sun Feb 26 19:00:55 2017	(r314306)
+++ head/sys/cam/ctl/scsi_ctl.c	Sun Feb 26 19:23:03 2017	(r314307)
@@ -1223,6 +1223,20 @@ ctlfedone(struct cam_periph *periph, uni
 		 * datamove done routine.
 		 */
 		if ((io->io_hdr.flags & CTL_FLAG_DMA_INPROG) == 0) {
+			/*
+			 * If we asked to send sense data but it wasn't sent,
+			 * queue the I/O back to CTL for later REQUEST SENSE.
+			 */
+			if ((done_ccb->ccb_h.flags & CAM_SEND_SENSE) != 0 &&
+			    (done_ccb->ccb_h.status & CAM_STATUS_MASK) == CAM_REQ_CMP &&
+			    (done_ccb->ccb_h.status & CAM_SENT_SENSE) == 0 &&
+			    (io = ctl_alloc_io_nowait(bus_softc->port.ctl_pool_ref)) != NULL) {
+				PRIV_INFO(io) = PRIV_INFO(
+				    (union ctl_io *)atio->ccb_h.io_ptr);
+				ctl_queue_sense(atio->ccb_h.io_ptr);
+				atio->ccb_h.io_ptr = io;
+			}
+
 			/* Abort ATIO if CTIO sending status has failed. */
 			if ((done_ccb->ccb_h.status & CAM_STATUS_MASK) !=
 			    CAM_REQ_CMP) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702261923.v1QJN3MJ065228>