Date: Fri, 25 Aug 2017 16:17:59 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306512 - in head/sys: kern sys Message-ID: <25ad986d-7a39-7854-5680-390c20a16743@FreeBSD.org> In-Reply-To: <20170825223752.GN1700@kib.kiev.ua> References: <201609301727.u8UHRIgD051373@repo.freebsd.org> <6ea06065-ea5c-b83b-3854-224626be0d77@FreeBSD.org> <20170825103534.GK1700@kib.kiev.ua> <c9233211-318b-802b-27e6-862808f9ea77@FreeBSD.org> <20170825223752.GN1700@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln Content-Type: multipart/mixed; boundary="XcVkcx4Ax0N4CvI0m0sJTwwIAQNHHrAqp"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <25ad986d-7a39-7854-5680-390c20a16743@FreeBSD.org> Subject: Re: svn commit: r306512 - in head/sys: kern sys References: <201609301727.u8UHRIgD051373@repo.freebsd.org> <6ea06065-ea5c-b83b-3854-224626be0d77@FreeBSD.org> <20170825103534.GK1700@kib.kiev.ua> <c9233211-318b-802b-27e6-862808f9ea77@FreeBSD.org> <20170825223752.GN1700@kib.kiev.ua> In-Reply-To: <20170825223752.GN1700@kib.kiev.ua> --XcVkcx4Ax0N4CvI0m0sJTwwIAQNHHrAqp Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/25/2017 3:37 PM, Konstantin Belousov wrote: > On Fri, Aug 25, 2017 at 02:29:28PM -0700, Bryan Drewery wrote: >> https://people.freebsd.org/~bdrewery/patches/vdrop-global-list.diff > I do not object against his handling. >=20 > There is really very small amount of code shared between mp !=3D NULL > and mp =3D=3D NULL cases, you may consider making them use separate pat= hs > instead of adding more than one check for mp !=3D NULL. >=20 Sure, and I incorrectly was adding VMP_TMPMNTFREELIST flag for mp=3D=3DNU= LL case. I'll open a review. > VNASSERT() statement has wrong indent on the continuation line. >=20 --=20 Regards, Bryan Drewery --XcVkcx4Ax0N4CvI0m0sJTwwIAQNHHrAqp-- --ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZoLAnAAoJEDXXcbtuRpfPRJ0IANds7jjlR2FGihpYQv0WqPvE 5ZGVBB8raABuIacEkeZUjnHP2eAcbNvAdg0LUvelIRRyTLKJI8pc/LR1tT45qZfU 36Zhher7I+75ymxYbnzhi/sQJ2CUiyzHORaByCJXHhVvUyysgEDNqyuZXCfF8fMB 3Kj+Ztlt8e5da4f6GPnzJSxG0qzzuU+JqMALWWu5rfNToUH0HyYOphMu+rqcgPki TvZ6z5rVgwMf6SfWpOvTf6qZh0p7Lt3wkKGdvpA96arkiGFCyBfUl3COkcr+5OU1 UTaOU5iQE2hD2RXneiIYi0vYnIkaKSBCMn0Y58EchGA6q4UBUFXGaai6wjSpi0c= =84mS -----END PGP SIGNATURE----- --ckNkO69sC6vSopMtmTNabeTjjuTFbw2Ln--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25ad986d-7a39-7854-5680-390c20a16743>