Date: Mon, 8 Jun 1998 11:48:23 +0200 (CEST) From: Søren Schmidt <sos@FreeBSD.ORG> To: dfr@nlsystems.com (Doug Rabson) Cc: sos@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa/snd ad1848.c sb_dsp.c sound.c Message-ID: <199806080948.LAA03144@sos.freebsd.dk> In-Reply-To: <Pine.BSF.3.95q.980608102935.351B-100000@herring.nlsystems.com> from Doug Rabson at "Jun 8, 98 10:29:57 am"
next in thread | previous in thread | raw e-mail | index | archive | help
In reply to Doug Rabson who wrote:
> On Mon, 8 Jun 1998, Sren Schmidt wrote:
>
> > sos 1998/06/08 02:00:29 PDT
> >
> > Modified files:
> > sys/i386/isa/snd ad1848.c sb_dsp.c sound.c
> > Log:
> > Correct even more ioctl breakage :(
> > Doesn't people check their code before committing anymore, it could
> > at least compile ????
>
> I built LINT. Perhaps these drivers should go into LINT.
Not to be rude or anything, but all the mess you've created with
these changes suggests to me that you didn't test this very well,
you should have had these changes reviewed by someone, but the log
doesn't say you did...
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team
Even more code to hack -- will it ever end
..
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806080948.LAA03144>