Date: Thu, 19 Sep 2002 07:40:36 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Julian Elischer <julian@elischer.org> Cc: Darren Reed <darrenr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c Message-ID: <9333.1032414036@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 18 Sep 2002 22:17:25 PDT." <Pine.BSF.4.21.0209182216020.10489-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.21.0209182216020.10489-100000@InterJet.elischer.org>, Ju lian Elischer writes: > > >On Thu, 19 Sep 2002, Poul-Henning Kamp wrote: > >> In message <200209190121.g8J1LPVf041328@freefall.freebsd.org>, Darren Reed writ >> es: >> >darrenr 2002/09/18 18:21:24 PDT >> > >> > Modified files: >> > sys/kern uipc_mbuf.c >> > Log: >> > If M_PKTHDR is set then we don't need to do a loop to find the total length. >> >> This should be backed out. > >Unfortunatly you hit the send key before you included your polite well >thought out reason.. Well, I was inspired by the radically terse, almost ablative commit message I saw the other day: Log: Completely redo thread states. :-) (Yes, I got in quite a hurry when I composed that message.) The reasons for this change being 100% wrong, are so obvious from almost any call to m_length() and from the mbuf(9) man-page, that it isn't really needed to argue about it, it should just be backed out, now, before it hurts anybody. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9333.1032414036>