Date: Tue, 4 Feb 2020 05:23:30 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Steve Wills <swills@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r525035 - in head/print: . xreader Message-ID: <20200204052330.GA3138@FreeBSD.org> In-Reply-To: <945c00bf-02a3-7bc8-70b8-e82e3b3900e8@FreeBSD.org> References: <202002031322.013DMSCA044267@repo.freebsd.org> <945c00bf-02a3-7bc8-70b8-e82e3b3900e8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 03, 2020 at 02:41:16PM -0500, Steve Wills wrote: > On 2/3/20 8:22 AM, Alexey Dokuchaev wrote: > > New Revision: 525035 > > URL: https://svnweb.freebsd.org/changeset/ports/525035 > > > > [...] Please don't overquote. :-) > > +post-patch: > > + @${REINPLACE_CMD} -e '/gdk\/gdkwayland\.h/d' \ > > + ${WRKSRC}/libdocument/ev-document-misc.h > > + > > This REINPLACE_CMD doesn't seem necessary, it seems to build fine for me > without this. It is needed, Steve: this header file is guarded by %%WAYLAND%% if you look inside `x11-toolkits/gtk30/pkg-plist', and many people disable this option. The header seems to be unused anyways, so I've just removed it unconditionally. > -USES= desktop-file-utils gettext-tools gnome meson pkgconfig > +USES= desktop-file-utils gettext-tools gnome meson pkgconfig xorg Indeed, I've missed this bit. > -MESON_ARGS= -Depub=false -Dtests=false > +MESON_ARGS= -Depub=false \ > + -Dtests=false This part is different now after r525048, but I don't see what's wrong with putting two short words on the same line: it does not sacrifice readability and makes Makefile a little shorter and thus easier to nagivate. > [ Gratuitous whitespace shuffling omitted ] I spend quite a lot of time on making sure my ports are well formatted, readable, easy to work with, and overall neat. The amount of whitespace is carefully calculated and correct as it is. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200204052330.GA3138>