Date: Wed, 3 Feb 2016 10:11:01 +0100 From: Guido Falsi <mad@madpilot.net> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r407901 - in head/net-mgmt/collectd5: . files Message-ID: <56B1C425.5090407@madpilot.net> In-Reply-To: <56B1BFBD.7030301@FreeBSD.org> References: <201602022308.u12N8kud098510@repo.freebsd.org> <20160203065658.GA77151@FreeBSD.org> <56B1BFBD.7030301@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/03/16 09:52, Guido Falsi wrote: > On 02/03/16 07:56, Alexey Dokuchaev wrote: >> On Tue, Feb 02, 2016 at 11:08:46PM +0000, Guido Falsi wrote: >>> New Revision: 407901 >>> URL: https://svnweb.freebsd.org/changeset/ports/407901 >>> >>> Log: >>> - Update to 5.5.1 >>> - Mark MONGODB option as BROKEN >> >> Commit log does not explain what's exactly broken, which makes it (the log) >> pretty useless. :( > > That information is in the PR, which is referenced by the commit > message, I thought that could be enough. > >> >>> +1,032 -2 head/net-mgmt/collectd5/files/patch-src__Makefile.in >> >> This huge patch suggests that it's probably better to patch Makefile.am and >> regenerate Makefile.in instead. > > I must admit I'm not an expert with the autotools so I took the > submitter's work for granted as long as it worked. > > I can try to fix this by working with him and see if we can get a better > patch. > Some further analysis shows that the port is already regenerating the .in files, most probably this patch slipped into the diff by mistake, I should have caught this. Sorry for the mistake, I'm making sure everything works fine without it and will commit a fix once sure. Thanks for reporting. -- Guido Falsi <mad@madpilot.net>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56B1C425.5090407>