Date: Fri, 16 Jan 2009 09:01:45 +0000 (UTC) From: Qing Li <qingli@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r187328 - head/sys/net Message-ID: <200901160901.n0G91j1T001431@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: qingli Date: Fri Jan 16 09:01:45 2009 New Revision: 187328 URL: http://svn.freebsd.org/changeset/base/187328 Log: The RTF_LLINFO was revived unconditionally, but within the kernel the check on the sysctl argument value being RTF_LLINFO is conditioned on the COMPAT_ROUTE_FLAGS kernel option. This mismatch caused the L2 table retrieval failure, and the arp/ndp -an command displays empty L2 tables. Reviewed by: pjd Modified: head/sys/net/rtsock.c Modified: head/sys/net/rtsock.c ============================================================================== --- head/sys/net/rtsock.c Fri Jan 16 08:38:03 2009 (r187327) +++ head/sys/net/rtsock.c Fri Jan 16 09:01:45 2009 (r187328) @@ -1448,11 +1448,7 @@ sysctl_rtsock(SYSCTL_HANDLER_ARGS) * specify an AF */ if (w.w_op == NET_RT_FLAGS && -#if defined(COMPAT_ROUTE_FLAGS) - (w.w_arg & RTF_LLINFO)) { -#else - w.w_arg == 0) { -#endif + (w.w_arg == 0 || w.w_arg & RTF_LLINFO)) { if (af != 0) error = lltable_sysctl_dumparp(af, w.w_req); else
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901160901.n0G91j1T001431>