Date: Fri, 12 Jul 2002 10:30:11 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: dl@catspoiler.org Cc: hsu@FreeBSD.org, truckman@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c Message-ID: <20020712.103011.56126329.imp@bsdimp.com> In-Reply-To: <200207121628.g6CGS3wr014471@gw.catspoiler.org> References: <20020712.101645.125311016.imp@bsdimp.com> <200207121628.g6CGS3wr014471@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200207121628.g6CGS3wr014471@gw.catspoiler.org>
Don Lewis <dl@catspoiler.org> writes:
: On 12 Jul, M. Warner Losh wrote:
: > In message: <0GZ4004U3MZCIJ@mta5.snfc21.pbi.net>
: > Jeffrey Hsu <hsu@FreeBSD.org> writes:
: > : > Lock inp while we're accessing it.
: > :
: > : Here's a rhetorical question: why? That inp was purposely left unlocked.
: >
: > I can only assume that he didn't have enough:
: >
: > ../../../vm/uma_core.c:1332: could sleep with "inp" locked from ../../../netinet/tcp_usrreq.c:536
: >
: > messages in his dmesg log.
:
: I checked in a fix for that violation last night. SYSCTL_OUT() can
: block, so calling it with a lock held will cause this error. This
: particular case was easy to fix by moving the call to SYSCTL_OUT()
: outside the locked region.
:-)
I was trying to make a small joke, but if you have fixed this
violation for real, I'll be very happy :-)
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020712.103011.56126329.imp>