Date: Wed, 14 Mar 2018 09:31:12 -0400 From: "Jason E. Hale" <jhale@freebsd.org> To: Pietro Cerutti <gahr@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r464480 - head/editors/mp Message-ID: <CAJE75NFe=Lgg5XPuJphZ-Ox_y%2BzzV%2BzaEfyxYeQ4%2Bg-ev9ok7Q@mail.gmail.com> In-Reply-To: <20180314130619.cboqfsyuifzzchzm@ptrcrt.ch> References: <201803141001.w2EA1Vo2042681@repo.freebsd.org> <CAJE75NGffzm1pAmuFTpP-w7CS%2BucRxq6o6GgbQY2a94gV8HACw@mail.gmail.com> <20180314130619.cboqfsyuifzzchzm@ptrcrt.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 14, 2018 at 9:06 AM, Pietro Cerutti <gahr@freebsd.org> wrote: > On Mar 14 18 08:38, Jason E. Hale wrote: >> >> On Wed, Mar 14, 2018 at 6:01 AM, Pietro Cerutti <gahr@freebsd.org> wrote: >>> >>> Author: gahr >>> Date: Wed Mar 14 10:01:31 2018 >>> New Revision: 464480 >>> URL: https://svnweb.freebsd.org/changeset/ports/464480 >>> >>> Log: >>> editors/mp: fix build with ncurses from base >>> >>> Modified: >>> head/editors/mp/Makefile >>> >>> Modified: head/editors/mp/Makefile >>> >>> ============================================================================== >>> --- head/editors/mp/Makefile Wed Mar 14 09:59:28 2018 (r464479) >>> +++ head/editors/mp/Makefile Wed Mar 14 10:01:31 2018 (r464480) >>> @@ -50,6 +50,7 @@ GTK3_CONFIGURE_ON= --with-gtk=3 >>> >>> NCURSES_USES= ncurses >>> NCURSES_CONFIGURE_WITH= curses >>> +NCURSES_CFLAGS= -I${NCURSESBASE}/include >>> >>> QT4_USE= qt4=corelib,gui,moc_build \ >>> xorg=x11 >>> >> >> Hmm...what was the build failure? It seemed to build fine in poudriere >> before this change. NCURSESINC is already passed through in >> CONFIGURE_ENV and I see it in ${WRKSRC}/config.cflags after configure >> is run. > > > The failure is at compile time, and it only happens if devel/ncurses is > installed - which I think it's why you didn't spot it in poudriere. > > The problem is not with this port per se, but with the fact that NCURSESINC > is set to ${LOCALBASE}/include/ncurses when using ncurses from ports. > ncurses.h includes <ncurses/ncurses_dll.h> which it cannot find, as > ${LOCALBASE}/include itself is not in the search path. > > The config.sh check for ncurses fails to compile the sample program with > this compile line: > > cc -O2 -pipe -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing > -I/usr/local/include/ncurses .tmp.c -Wl,--as-needed > '-Wl,-rpath=/usr/local/lib' -fstack-protector -L/usr/local/lib -lncursesw -o > .tmp.o > > As you see, -I${LOCALBASE}/include is missing, so ncurses.h doesn't find > ncurses/ncurses_dll.h. > > So, the issue is more fundamental within Uses/ncurses.mk or within how the > ncurses port installs itself (depends how you see it). > > This was a quick fix to allow the port to be built. > I see. Thanks for the explanation and the fix!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NFe=Lgg5XPuJphZ-Ox_y%2BzzV%2BzaEfyxYeQ4%2Bg-ev9ok7Q>