Date: Sat, 12 Jul 2008 21:47:44 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Ion-Mihai Tetcu <itetcu@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/apache13-ssl Makefile pkg-plist ports/www/apache13-ssl/files apache.in apache.sh extra-patch-noportdocs Message-ID: <487988F0.9080306@FreeBSD.org> In-Reply-To: <200807130437.m6D4bf1u097284@repoman.freebsd.org> References: <200807130437.m6D4bf1u097284@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ion-Mihai Tetcu wrote: > itetcu 2008-07-13 04:37:41 UTC > > FreeBSD ports repository > > Modified files: > www/apache13-ssl Makefile pkg-plist > Added files: > www/apache13-ssl/files apache.in extra-patch-noportdocs > Removed files: > www/apache13-ssl/files apache.sh > Log: > - Honor NO* vars (noticed by ionbot) > - Silence some portlint warnings > - USE_RC_SUBR from the rc.d script > - Bump PORTREVISION > > PR: 125131 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=125131 > Submitted by: Philip M. Gollucci > > Revision Changes Path > 1.123 +8 -11 ports/www/apache13-ssl/Makefile > 1.1 +63 -0 ports/www/apache13-ssl/files/apache.in (new) > 1.3 +0 -62 ports/www/apache13-ssl/files/apache.sh (dead) > 1.1 +22 -0 ports/www/apache13-ssl/files/extra-patch-noportdocs (new) > 1.29 +8 -9 ports/www/apache13-ssl/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/Makefile.diff?&r1=1.122&r2=1.123&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/files/apache.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/files/apache.sh > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/files/extra-patch-noportdocs > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/pkg-plist.diff?&r1=1.28&r2=1.29&f=h Overall the rc.d changes look good. The only (non-crucial) change I'd make is to put load_rc_config before the tests for empty variables. hth, Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?487988F0.9080306>