Date: Thu, 19 Oct 2017 20:57:24 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Steve Wills <swills@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Shane <FreeBSD@ShaneWare.Biz> Subject: Re: svn commit: r452416 - in head/graphics/opensubdiv: . files Message-ID: <20171019205724.14cb4ded@kalimero.tijl.coosemans.org> In-Reply-To: <376f-c8kf-wny@FreeBSD.org> References: <201710191219.v9JCJbHV026836@repo.freebsd.org> <1slz-gioy-wny@FreeBSD.org> <20171019200428.104dc058@kalimero.tijl.coosemans.org> <376f-c8kf-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 19 Oct 2017 20:10:40 +0200 Jan Beich <jbeich@FreeBSD.org> wrote: > Tijl Coosemans <tijl@FreeBSD.org> writes: >> On Thu, 19 Oct 2017 19:18:21 +0200 Jan Beich <jbeich@FreeBSD.org> wrote: >>> Steve Wills <swills@FreeBSD.org> writes: >>>> + ${FIND} ${WRKSRC}/regression -name CMakeLists.txt | ${XARGS} ${REINPLACE_CMD} \ >>>> + -e 's|{CMAKE_BINDIR_BASE}|{CMAKE_INSTALL_PREFIX}/share/${PORTNAME}/test|g' >>> >>> According to hier(7) and devel/kyua tests should probably go under >>> tests/${PORTNAME}. >>> >>> Why use xargs(1) for a feature built into find(1)? >>> >>> -exec utility [argument ...] {} + >>> Same as -exec, except that "{}" is replaced with as many >>> pathnames as possible for each invocation of utility. This >>> behaviour is similar to that of xargs(1). The primary always >>> returns true; if at least one invocation of utility returns a >>> non-zero exit status, find will return a non-zero exit status. >>> >> >> XARGS is usually faster because find runs the command for every file >> while xargs batches all files in a single command. > > Did you mistake "-exec ... {} +" for "-exec ... {} ;" ? Huh, added in 2002, I guess I haven't read that manpage in a long time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171019205724.14cb4ded>