Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 May 2006 21:21:42 GMT
From:      John Birrell <jb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 97210 for review
Message-ID:  <200605152121.k4FLLgAP042893@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=97210

Change 97210 by jb@jb_freebsd2 on 2006/05/15 21:20:46

	Based on a suggestion from Sun, change the tests that reference 'kmem_flags'
	(which is Solaris kernel-specific) to reference 'dtrace_zero' which
	is a variable in the dtrace device used for testing and demonstration.
	
	There are 3 tests that I'm not really sure how to 'fix'. I can make those
	tests pass, but in doing so I will probably change them away from what
	they were intended to test. Creating tests like this requires knowledge
	of the DTrace parser design and the language it implements. I'm not that
	knowledgeable yet (ever?), so I think it's best not to waste a lot of
	time. There are bigger fish to fry. Or grill.
	
	The pass count is now 786.

Affected files ...

.. //depot/projects/dtrace/src/cddl/test/dtrace/Makefile#12 edit

Differences ...

==== //depot/projects/dtrace/src/cddl/test/dtrace/Makefile#12 (text+ko) ====

@@ -124,6 +124,8 @@
 	${.CURDIR}/tst/common/arrays/tst.basic6.d
 
 TESTASSOCS= \
+	${.CURDIR}/tst/common/assocs/err.D_OP_INCOMPAT.dupgtype.d \
+	${.CURDIR}/tst/common/assocs/err.D_OP_INCOMPAT.dupttype.d \
 	${.CURDIR}/tst/common/assocs/err.D_OP_INCOMPAT.this.d \
 	${.CURDIR}/tst/common/assocs/err.D_PROTO_ARG.badsig.d \
 	${.CURDIR}/tst/common/assocs/err.D_PROTO_LEN.toofew.d \
@@ -371,6 +373,7 @@
 	${.CURDIR}/tst/common/funcs/err.copyoutstrbadaddr.ksh \
 	${.CURDIR}/tst/common/funcs/tst.badfreopen.ksh \
 	${.CURDIR}/tst/common/funcs/tst.basename.d \
+	${.CURDIR}/tst/common/funcs/tst.bcopy.d \
 	${.CURDIR}/tst/common/funcs/tst.cleanpath.d \
 	${.CURDIR}/tst/common/funcs/tst.default.d \
 	${.CURDIR}/tst/common/funcs/tst.ftruncate.ksh \
@@ -396,6 +399,7 @@
 	${.CURDIR}/tst/common/inline/err.D_IDENT_UNDEF.recur.d \
 	${.CURDIR}/tst/common/inline/err.D_OP_INCOMPAT.baddef1.d \
 	${.CURDIR}/tst/common/inline/err.D_OP_INCOMPAT.baddef2.d \
+	${.CURDIR}/tst/common/inline/tst.InlineTypedef.d \
 	${.CURDIR}/tst/common/inline/tst.InlineWritableAssign.d
 
 TESTLEXER= \
@@ -465,6 +469,7 @@
 	${.CURDIR}/tst/common/pointers/tst.ArrayPointer1.d \
 	${.CURDIR}/tst/common/pointers/tst.ArrayPointer2.d \
 	${.CURDIR}/tst/common/pointers/tst.ArrayPointer3.d \
+	${.CURDIR}/tst/common/pointers/tst.GlobalVar.d \
 	${.CURDIR}/tst/common/pointers/tst.IntegerArithmetic1.d \
 	${.CURDIR}/tst/common/pointers/tst.PointerArithmetic1.d \
 	${.CURDIR}/tst/common/pointers/tst.PointerArithmetic2.d \
@@ -472,7 +477,9 @@
 	${.CURDIR}/tst/common/pointers/tst.PointerAssignment.d \
 	${.CURDIR}/tst/common/pointers/tst.ValidPointer1.d \
 	${.CURDIR}/tst/common/pointers/tst.ValidPointer2.d \
-	${.CURDIR}/tst/common/pointers/tst.VoidCast.d
+	${.CURDIR}/tst/common/pointers/tst.VoidCast.d \
+	${.CURDIR}/tst/common/pointers/tst.basic1.d \
+	${.CURDIR}/tst/common/pointers/tst.basic2.d
 
 TESTPRAGMA= \
 	${.CURDIR}/tst/common/pragma/err.D_PRAGERR.d \
@@ -625,9 +632,13 @@
 	${.CURDIR}/tst/common/scalars/err.D_DECL_CLASS.thisself.d \
 	${.CURDIR}/tst/common/scalars/err.D_DECL_IDRED.errval.d \
 	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dec.err.d \
+	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupgtype.d \
+	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupltype.d \
+	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupttype.d \
 	${.CURDIR}/tst/common/scalars/err.D_SYNTAX.declare.d \
 	${.CURDIR}/tst/common/scalars/tst.basicvar.d \
 	${.CURDIR}/tst/common/scalars/tst.localvar.d \
+	${.CURDIR}/tst/common/scalars/tst.misc.d \
 	${.CURDIR}/tst/common/scalars/tst.self.d \
 	${.CURDIR}/tst/common/scalars/tst.selfarray.d \
 	${.CURDIR}/tst/common/scalars/tst.selfthis.d \
@@ -755,6 +766,7 @@
 	${.CURDIR}/tst/common/tick-n/tst.tickusec.d
 
 TESTTRACE= \
+	${.CURDIR}/tst/common/trace/err.D_TRACE_VOID.bad.d \
 	${.CURDIR}/tst/common/trace/err.D_PROTO_LEN.bad.d \
 	${.CURDIR}/tst/common/trace/tst.qstring.d \
 	${.CURDIR}/tst/common/trace/tst.string.d
@@ -806,6 +818,7 @@
 	${.CURDIR}/tst/common/typedef/tst.TypedefDataAssign.d
 
 TESTTYPES= \
+	${.CURDIR}/tst/common/types/err.D_CAST_INVAL.badcast.d \
 	${.CURDIR}/tst/common/types/err.D_CHR_OFLOW.charconst.d \
 	${.CURDIR}/tst/common/types/err.D_DECL_BADCLASS.bad.d \
 	${.CURDIR}/tst/common/types/err.D_DECL_CHARATTR.badtype3.d \
@@ -844,6 +857,8 @@
 	${.CURDIR}/tst/common/types/tst.intincop.d \
 	${.CURDIR}/tst/common/types/tst.intops.d \
 	${.CURDIR}/tst/common/types/tst.inttypes.d \
+	${.CURDIR}/tst/common/types/tst.ptrincop.d \
+	${.CURDIR}/tst/common/types/tst.ptrops.d \
 	${.CURDIR}/tst/common/types/tst.relenum.d \
 	${.CURDIR}/tst/common/types/tst.relstring.d \
 	${.CURDIR}/tst/common/types/tst.shiftops.d \
@@ -1227,6 +1242,9 @@
 	${.CURDIR}/tst/common/dtraceUtil/tst.ZeroProviderProbes.d.ksh \
 	${.CURDIR}/tst/common/error/tst.DTRACEFLT_BADADDR.d \
 	${.CURDIR}/tst/common/error/tst.DTRACEFLT_UNKNOWN.d \
+	${.CURDIR}/tst/common/inline/tst.InlineDataAssign.d \
+	${.CURDIR}/tst/common/inline/tst.InlineExpression.d \
+	${.CURDIR}/tst/common/pointers/err.D_OP_LVAL.AddressChange.d \
 	${.CURDIR}/tst/common/printa/tst.walltimestamp.d \
 	${.CURDIR}/tst/common/printf/tst.basics.d \
 	${.CURDIR}/tst/common/profile-n/tst.argtest.d \
@@ -1299,26 +1317,6 @@
 	${.CURDIR}/tst/common/safety/tst.vahole.d \
 	${.CURDIR}/tst/common/safety/tst.violentdeath.ksh
 
-REQUIRES_KMEM_FLAGS= \
-	${.CURDIR}/tst/common/assocs/err.D_OP_INCOMPAT.dupgtype.d \
-	${.CURDIR}/tst/common/assocs/err.D_OP_INCOMPAT.dupttype.d \
-	${.CURDIR}/tst/common/funcs/tst.bcopy.d \
-	${.CURDIR}/tst/common/inline/tst.InlineDataAssign.d \
-	${.CURDIR}/tst/common/inline/tst.InlineExpression.d \
-	${.CURDIR}/tst/common/inline/tst.InlineTypedef.d \
-	${.CURDIR}/tst/common/pointers/err.D_OP_LVAL.AddressChange.d \
-	${.CURDIR}/tst/common/pointers/tst.GlobalVar.d \
-	${.CURDIR}/tst/common/pointers/tst.basic1.d \
-	${.CURDIR}/tst/common/pointers/tst.basic2.d \
-	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupgtype.d \
-	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupltype.d \
-	${.CURDIR}/tst/common/scalars/err.D_OP_INCOMPAT.dupttype.d \
-	${.CURDIR}/tst/common/scalars/tst.misc.d \
-	${.CURDIR}/tst/common/trace/err.D_TRACE_VOID.bad.d \
-	${.CURDIR}/tst/common/types/err.D_CAST_INVAL.badcast.d \
-	${.CURDIR}/tst/common/types/tst.ptrincop.d \
-	${.CURDIR}/tst/common/types/tst.ptrops.d
-
 REQUIRES_LIBPROC= \
 	${.CURDIR}/tst/common/vars/tst.ucaller.ksh \
 	${.CURDIR}/tst/common/misc/tst.schrock.ksh



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605152121.k4FLLgAP042893>