Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Jul 2015 11:34:27 -0400
From:      Kris Moore <kris@pcbsd.org>
To:        koobs@FreeBSD.org, Li-Wen Hsu <lwhsu@FreeBSD.org>,  Kris Moore <kmoore@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r392000 - in head/textproc: . py-alabaster py-snowballstemmer
Message-ID:  <55A67D83.30307@pcbsd.org>
In-Reply-To: <55A63ECC.1080109@FreeBSD.org>
References:  <201507141420.t6EEKEku024783@repo.freebsd.org> <20150715044253.GB77591@FreeBSD.cs.nctu.edu.tw> <55A63ECC.1080109@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 07/15/2015 07:06, Kubilay Kocak wrote:
> On 15/07/2015 2:42 PM, Li-Wen Hsu wrote:
>> On 二,  7 14, 2015 at 14:20:14 +0000, Kris Moore wrote:
>>> Added: head/textproc/py-snowballstemmer/Makefile
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/textproc/py-snowballstemmer/Makefile	Tue Jul 14 14:20:13 2015	(r392000)
>>> @@ -0,0 +1,17 @@
>>> +# $FreeBSD$
>>> +
>>> +PORTNAME=	snowballstemmer
>>> +PORTVERSION=	1.2.0
>>> +CATEGORIES=	textproc python
>>> +MASTER_SITES=	CHEESESHOP
>>> +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
>>> +
>>> +MAINTAINER=	kmoore@FreeBSD.org
>>> +COMMENT=	Pure Python stemming library
>>> +
>>> +LICENSE=	MIT
>>> +
>>> +USES=		python
>>> +USE_PYTHON=	distutils autoplist
>>> +
>>> +.include <bsd.port.mk>
>>>
>>> Added: head/textproc/py-snowballstemmer/distinfo
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/textproc/py-snowballstemmer/distinfo	Tue Jul 14 14:20:13 2015	(r392000)
>>> @@ -0,0 +1,2 @@
>>> +SHA256 (snowballstemmer-1.2.0.tar.gz) = 6d54f350e7a0e48903a4e3b6b2cabd1b43e23765fbc975065402893692954191
>>> +SIZE (snowballstemmer-1.2.0.tar.gz) = 49639
>>>
>>> Added: head/textproc/py-snowballstemmer/pkg-descr
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/textproc/py-snowballstemmer/pkg-descr	Tue Jul 14 14:20:13 2015	(r392000)
>>> @@ -0,0 +1,4 @@
>>> +This is a pure Python stemming library. If PyStemmer is
>>> +available, this module uses it to accelerate.
>>> +
>>> +WWW: https://pypi.python.org/pypi/snowballstemmer
>> I'm also working on py-sphinx update, and going to add this port.  Since
>> it says "If PyStemmer is available, this module uses it to accelerate."
>> How do you think about the attached patch?  Also, I think its license is
>> BSD2CALUSE, and the COMMENT might be more suitable.
>>
>> Please note that patch needs renaming textproc/pystemmer to
>> textproc/py-pystemmer, I think it's fine and better, since it (only)
>> install things to PYTHON_SITELIBDIR.
>>
>> Li-Wen
>>
> Agreed Li-Wen.
>
> Things should be named py-<name> no matter the name, including when that
> name is prefixed with py, python or otherwise. This is especially
> necessary when modules/packages are listed on PyPI (CHEESESHOP)
>
> In particular, this:
>
>  - Avoids naming conflicts (there are *many* examples of
> unique/different packages named foo and pyfoo on PyPI)
>  - Easy discoverability by users who know the name of the module they
> want (using pip or requirements files)
>  - Google Juice benefits for FreeBSD/Ports/FreshPorts
>
> We have a python ports policy in progress:
> https://wiki.freebsd.org/Python/PortsPolicy that outlines the above in
> more detail
>
> ./koobs

Li-Wen,

Patch looks good  to me, go ahead and commit whenever you have a chance.

-- 
Kris Moore
PC-BSD Software / iXsystems
Enterprise Storage & Servers Driven By Open Source




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55A67D83.30307>