Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Dec 2008 18:19:22 +0100 (CET)
From:      Ulrich Spoerlein <uspoerlein@gmail.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        mark@foster.cc
Subject:   ports/129617: [PATCH] audio/firefly: depend on sqlite3 / fix rc script warning
Message-ID:  <200812131719.mBDHJMSw041285@roadrunner.spoerlein.net>
Resent-Message-ID: <200812131720.mBDHK3I2042353@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         129617
>Category:       ports
>Synopsis:       [PATCH] audio/firefly: depend on sqlite3 / fix rc script warning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 13 17:20:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD roadrunner.spoerlein.net 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Sat Nov  8 20:43:48 CET
>Description:
- Depend on sqlite3, which is more likely to be already installed than sqlite2
- Fix a warning when no firefly_enable var is set in rc.conf

Port maintainer (mark@foster.cc) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- firefly-1696_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /tank/ncvs/ports/audio/firefly/Makefile,v
retrieving revision 1.1
diff -u -p -u -r1.1 Makefile
--- Makefile	19 Oct 2008 15:59:15 -0000	1.1
+++ Makefile	13 Dec 2008 17:18:18 -0000
@@ -6,6 +6,7 @@
 
 PORTNAME=	firefly
 PORTVERSION=	1696
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	http://nightlies.fireflymediaserver.org/nightlies/svn-${PORTVERSION}/ \
 		http://www.magnesium.net/~mdf/distfiles/
@@ -19,7 +20,7 @@ BUILD_DEPENDS=	${LOCALBASE}/include/vorb
 RUN_DEPENDS=	oggdec:${PORTSDIR}/audio/vorbis-tools \
 		flac:${PORTSDIR}/audio/flac
 LIB_DEPENDS=	ogg:${PORTSDIR}/audio/libogg \
-		sqlite:${PORTSDIR}/databases/sqlite2 \
+		sqlite3.8:${PORTSDIR}/databases/sqlite3 \
 		id3tag.0:${PORTSDIR}/audio/libid3tag
 
 CONFLICTS=	mt-daapd-0.2.*
@@ -30,7 +31,7 @@ CONFIGURE_ENV=	CFLAGS="${CFLAGS} ${PTHRE
 		LDFLAGS="-L${LOCALBASE}/lib" \
 		LIBS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}"
 CONFIGURE_TARGET=	--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
-CONFIGURE_ARGS=		--prefix=${LOCALBASE} --with-id3tag=${PREFIX} --enable-sqlite --enable-oggvorbis --enable-flac
+CONFIGURE_ARGS=		--prefix=${LOCALBASE} --with-id3tag=${PREFIX} --enable-sqlite3 --enable-oggvorbis --enable-flac
 
 #USE_AUTOTOOLS=	autoheader:261 autoconf:261:env
 
Index: files/mt-daapd.in
===================================================================
RCS file: /tank/ncvs/ports/audio/firefly/files/mt-daapd.in,v
retrieving revision 1.1
diff -u -p -u -r1.1 mt-daapd.in
--- files/mt-daapd.in	19 Oct 2008 15:59:15 -0000	1.1
+++ files/mt-daapd.in	13 Dec 2008 17:18:18 -0000
@@ -6,8 +6,10 @@
 
 . %%RC_SUBR%%
 
+: ${firefly_enable=NO}
+
 name="firefly"
-rcvar="firefly_enable"
+rcvar="`set_rcvar`"
 
 command="%%PREFIX%%/sbin/mt-daapd"
 command_args="-c %%PREFIX%%/etc/mt-daapd.conf"
--- firefly-1696_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812131719.mBDHJMSw041285>