Date: Thu, 13 Aug 2020 13:19:02 +0200 From: Adriaan de Groot <adridg@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r496814 - in head: net-im net-im/mtxclient net-im/mtxclient/files security security/olm Message-ID: <7526637.L6bdSy1Yio@beastie.bionicmutton.org> In-Reply-To: <20200807130322.GA67139@FreeBSD.org> References: <201903251040.x2PAegVl021649@repo.freebsd.org> <20200807130322.GA67139@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart2054750.YXp4yczo3S Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Friday, 7 August 2020 15:03:22 CEST Alexey Dokuchaev wrote: > On Mon, Mar 25, 2019 at 10:40:42AM +0000, Adriaan de Groot wrote: > > New Revision: 496814 > > URL: https://svnweb.freebsd.org/changeset/ports/496814 > > > > Log: > > New ports security/olm and net-im/mtxclient > > > > These are support libraries for Matrix clients; Nheko in particular. > > Until I wrap-up Nheko, they aren't used by anything. > > > > Added: head/net-im/mtxclient/Makefile > > ... > > + > > +BUILD_DEPENDS= nlohmann-json>=3:devel/nlohmann-json \ > > + spdlog>=1.3:devel/spdlog \ \ > > Ouch, `devel/googletest' in BUILD_DEPENDS, that's gross! "that's gross" is not a particularly meaningful comment. I have no idea what you're getting at (especially not four months after-the-fact). > Would you > kindly consider dropping the hard dependency and adding CMAKE_ARGS= > -DBUILD_LIB_TESTS:BOOL=OFF instead? Sure. Generally I package things up with as little change from upstream as possible. By default mtxclient **does** build tests, and to do so has certain straightforward dependencies. I don't usually see a reason to reduce testing or validity checking during builds. So .. whatevs? It's just a build dep, doesn't affect the installed package at all. [ade] --nextPart2054750.YXp4yczo3S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEhrjttu2OP5apuuy1z93JbxKxkVwFAl81IaYACgkQz93JbxKx kVxNwQv+OhE+lpYbapouSorfZJQ2X1wYnWD3+x75wtHR3pwhDR6mDVrg1ptKgJjV tAQCgBKrQSEMQjnZLpbn3sfxIj1xJGw7FzSDEQFWZjUEH8WzhSeu6dQSiHONo5Wp 79WycJhnfObr1+bRjEHiCvHrcTsRMRuJ9s8lLJ5jPXd1Ql7UivrOIxYu2seGjtYS NpYIw/EQ3/q4krEYJ/amfkQ8XOdQVK5vzEhkK4Xo4W3gxg9NiGokXDifCRlKT34u iKVeVwbB1+yUv1uCQgCFg8gkvKzsiwSGiYiHmLZ0Vmql6jpq4nL+o2iRbnAHhKsg YyTdyRol3SgrhRkyDr6HVA4YdR9i5ruN++9+AQE3NZyKUodRLPCWNhTo5LaeZGCY TSN0M/zsPgUZ9WHnrFXznGi6TsTOWlprFtJIbhEj2hZwnKqrS85lrxeNj+GAj3Cl lYdqhts5v1gSLAsJzptol+0gp16qj9PnwSkAE9e0qBBc2hIU9/qp7j/7VAtc6e3J NLhTFVl2 =n9rP -----END PGP SIGNATURE----- --nextPart2054750.YXp4yczo3S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7526637.L6bdSy1Yio>