Date: Wed, 11 Feb 2015 15:31:30 +0000 From: Brooks Davis <brooks@freebsd.org> To: Chris Torek <chris.torek@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: LOCAL_MTREE vs DB_FROM_SRC Message-ID: <20150211153130.GB23837@spindle.one-eyed-alien.net> In-Reply-To: <CAPx1Gvf8v1q2JkmzYF9ryoPk=XKYTiUG7gnu5TDXGn_7kqLd%2BQ@mail.gmail.com> References: <CAPx1Gvf8v1q2JkmzYF9ryoPk=XKYTiUG7gnu5TDXGn_7kqLd%2BQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--yNb1oOkm5a9FJOVX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Feb 10, 2015 at 06:43:06PM -0800, Chris Torek wrote:
> (Apologies for google mail, I moved a while back and my office at home is
> still not up and hence my regular FreeBSD machine at home is also not up.)
>=20
> In Makefile.inc1 we have:
>=20
> .if defined(DB_FROM_SRC)
> INSTALLFLAGS+=3D -N ${.CURDIR}/etc
> MTREEFLAGS+=3D -N ${.CURDIR}/etc
> .endif
>=20
> which is fine as far as it goes, but then if ${LOCAL_MTREE} is defined we
> have this:
>=20
> .for _mtree in ${LOCAL_MTREE}
> mtree -deU -f ${.CURDIR}/${_mtree} -p ${WORLDTMP} > /dev/null
> .endfor
>=20
> which omits the -N flag, even with DB_FROM_SRC set. This means if a local
> mtree file "wants" user and/or group names that are not on your build
> system, but are in the new (but not yet installed anywhere) master.passwd
> and/or group files, the build fails when prepping the worldtmp area. See=
ms
> like this should be "mtree ${MTREEFLAGS} ...", shouldn't it?
That seems correct to me. I think I failed to add ${MTREEFLAGS} because
I didn't resolve how LOCAL_MTREE and master.passwd/group were going to
interact.
-- Brooks
--yNb1oOkm5a9FJOVX
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlTbddEACgkQXY6L6fI4GtR62ACfeiuDarg6pKo7Rj2fFRVB2Ot9
qKUAnRF3eU69+4VOg3n0p8MxcYw35vCO
=kASN
-----END PGP SIGNATURE-----
--yNb1oOkm5a9FJOVX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150211153130.GB23837>