Date: Fri, 6 Jul 2007 18:59:45 +0200 (CEST) From: Michael Nottebrock <lofi@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: markus@FreeBSD.org Subject: ports/114367: Fix crash on JPEG metadata exceptions in Gwenview Message-ID: <200707061659.l66Gxj1n083175@kiste.my.domain> Resent-Message-ID: <200707061930.l66JU4nN024640@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 114367 >Category: ports >Synopsis: Fix crash on JPEG metadata exceptions in Gwenview >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jul 06 19:30:04 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Michael Nottebrock >Release: FreeBSD 5.5-RELEASE-p11 i386 >Organization: >Environment: System: FreeBSD kiste 5.5-RELEASE-p11 FreeBSD 5.5-RELEASE-p11 #4: Wed May 2 13:59:49 CEST 2007 root@kiste:/usr/obj/usr/src/sys/KISTE-SMP i386 >Description: Gwenview 1.4.1 as distributed contains a bug that can cause crashes when invalid JPEG metadata is encountered. >How-To-Repeat: http://bugs.kde.org/show_bug.cgi?id=138467 >Fix: The attached patch fixes the problem (Obtained from: KDE SVN). --- gwenview.diff begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/graphics/gwenview/Makefile,v retrieving revision 1.23 diff -u -r1.23 Makefile --- Makefile 19 May 2007 20:09:29 -0000 1.23 +++ Makefile 6 Jul 2007 16:55:55 -0000 @@ -7,7 +7,7 @@ PORTNAME= gwenview PORTVERSION= 1.4.1 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= graphics kde MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} Index: files/patch-src-imageutils-jpegcontent.cpp =================================================================== RCS file: files/patch-src-imageutils-jpegcontent.cpp diff -N files/patch-src-imageutils-jpegcontent.cpp --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-src-imageutils-jpegcontent.cpp 6 Jul 2007 16:55:55 -0000 @@ -0,0 +1,15 @@ +--- src/imageutils/jpegcontent.cpp.orig Fri Jul 6 18:37:46 2007 ++++ src/imageutils/jpegcontent.cpp Fri Jul 6 18:38:24 2007 +@@ -255,11 +255,11 @@ + Exiv2::Image::AutoPtr image; + try { + image = Exiv2::ImageFactory::open((unsigned char*)data.data(), data.size()); ++ image->readMetadata(); + } catch (Exiv2::Error&) { + kdError() << "Could not load image with Exiv2\n"; + return false; + } +- image->readMetadata(); + + d->mExifData = image->exifData(); + d->mComment = QString::fromUtf8( image->comment().c_str() ); --- gwenview.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707061659.l66Gxj1n083175>