Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jan 2017 09:16:51 -0500
From:      "Jason E. Hale" <jhale@freebsd.org>
To:        Mark Felder <feld@freebsd.org>
Cc:        ports-committers <ports-committers@freebsd.org>,  "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,  "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r430992 - head/graphics/py-pillow
Message-ID:  <CAJE75NEGCdpR8jY-oXDOy=4QMYUY=5uOBxEpF4bErf8-pGzgcA@mail.gmail.com>
In-Reply-To: <201701091800.v09I01Te005381@repo.freebsd.org>
References:  <201701091800.v09I01Te005381@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 9, 2017 at 1:00 PM, Mark Felder <feld@freebsd.org> wrote:
> Author: feld
> Date: Mon Jan  9 18:00:01 2017
> New Revision: 430992
> URL: https://svnweb.freebsd.org/changeset/ports/430992
>
> Log:
>   graphics/py-pillow: Update to 3.4.2 (security fixes)
>
>   - Update to 3.4.2
>   - Add JPEG2000 option
>
>   Changes:      https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst
>
>   PR:           215615
>   MFH:          2017Q1
>
> Modified:
>   head/graphics/py-pillow/Makefile
>   head/graphics/py-pillow/distinfo
>
> Modified: head/graphics/py-pillow/Makefile
> ==============================================================================
> --- head/graphics/py-pillow/Makefile    Mon Jan  9 17:41:22 2017        (r430991)
> +++ head/graphics/py-pillow/Makefile    Mon Jan  9 18:00:01 2017        (r430992)
> @@ -2,8 +2,7 @@
>  # $FreeBSD$
>
>  PORTNAME=      pillow
> -PORTVERSION=   3.1.1
> -PORTREVISION=  1
> +PORTVERSION=   3.4.2
>  CATEGORIES=    graphics python
>  PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
>
> @@ -15,8 +14,8 @@ LICENSE_NAME= Standard PIL License
>  LICENSE_FILE=  ${WRKSRC}/LICENSE
>  LICENSE_PERMS= dist-mirror dist-sell pkg-mirror pkg-sell auto-accept
>
> -OPTIONS_DEFINE=                FREETYPE JPEG LCMS PNG TIFF TKINTER WEBP
> -OPTIONS_DEFAULT=       FREETYPE JPEG PNG TKINTER WEBP
> +OPTIONS_DEFINE=                FREETYPE JPEG JPEG2000 LCMS PNG TIFF TKINTER WEBP
> +OPTIONS_DEFAULT=       FREETYPE JPEG JPEG2000 PNG TKINTER WEBP
>
>  LCMS_DESC=             Little Color Management System
>  TKINTER_DESC=          Tkinter (Tcl/Tk) BitmapImage & PhotoImage support
> @@ -29,6 +28,10 @@ JPEG_USES=           jpeg
>  JPEG_VARS=             PYDISTUTILS_BUILDARGS+=--enable-jpeg
>  JPEG_VARS_OFF=         PYDISTUTILS_BUILDARGS+=--disable-jpeg
>
> +JPEG2000_LIB_DEPENDS=  libopenjp2.so:graphics/openjpeg
> +JPEG2000_VARS=         PYDISTUTILS_BUILDARGS+=--enable-jpeg2000
> +JPEG2000_VARS_OFF=     PYDISTUTILS_BUILDARGS+=--disable-jpeg2000
> +

No description was added for the JPEG2000 option, so it is coming up
blank in the dialog. This option should probably be renamed to
OPENJPEG instead, as there is already a standard description for that
in bsd.options.desc.mk. I think we should strive to stick to the
standard description variables as much as possible so it is easier for
end-users to maintain global defaults.

-Jason



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJE75NEGCdpR8jY-oXDOy=4QMYUY=5uOBxEpF4bErf8-pGzgcA>