Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 May 2015 00:47:37 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Kris Moore <kmoore@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r385072 - head/x11/lumina
Message-ID:  <h9rx-w7w6-wny@FreeBSD.org>
In-Reply-To: <201504302212.t3UMClq7091335@svn.freebsd.org> (Kris Moore's message of "Thu, 30 Apr 2015 22:12:47 %2B0000 (UTC)")
References:  <201504302212.t3UMClq7091335@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Kris Moore <kmoore@FreeBSD.org> writes:

> -PORTVERSION=3D	0.8.3.${GITVERSION}
> -PORTEPOCH=3D	1
> +PORTVERSION=3D	0.8.4
> +PORTREVISION=3D	1

PORTEPOCH cannot be removed.

$ portlint -C
FATAL: Makefile: lumina-0.8.4_1 < lumina-0.8.3.1427733141,1. Choose another=
 PORTVERSION or bump PORTEPOCH.

> +USE_GITHUB=3D     yes
> +GH_ACCOUNT=3D     pcbsd
> +GH_COMMIT=3D      01bfb64
> +GH_TAGNAME=3D     v0.8.4-Release-P1

GH_COMMIT is deprecated and GH_TAGNAME is often a superset of PORTVERSION.
Also, spaces instead of tabs.

$ portlint -C
FATAL: Makefile: [43]: use a tab (not space) after a variable name
FATAL: Makefile: [44]: use a tab (not space) after a variable name
FATAL: Makefile: [45]: use a tab (not space) after a variable name
FATAL: Makefile: [46]: use a tab (not space) after a variable name

Index: x11/lumina/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- x11/lumina/Makefile	(revision 385072)
+++ x11/lumina/Makefile	(working copy)
@@ -3,7 +3,9 @@
=20
 PORTNAME=3D	lumina
 PORTVERSION=3D	0.8.4
=2DPORTREVISION=3D	1
+DISTVERSIONPREFIX=3Dv
+DISTVERSIONSUFFIX=3D-Release-P1
+PORTEPOCH=3D	1
 CATEGORIES=3D	x11
=20
 MAINTAINER=3D	kmoore@FreeBSD.org
@@ -40,10 +42,8 @@ USE_LDCONFIG=3D	yes
 USE_QT5=3D	core gui network svg linguist multimedia imageformats \
 		buildtools x11extras
 USES=3D		qmake tar:bzip2
=2DUSE_GITHUB=3D     yes
=2DGH_ACCOUNT=3D     pcbsd
=2DGH_COMMIT=3D      01bfb64
=2DGH_TAGNAME=3D     v0.8.4-Release-P1
+USE_GITHUB=3D	yes
+GH_ACCOUNT=3D	pcbsd
=20
 QMAKE_ARGS=3D	CONFIG+=3D"configure"
=20
Index: x11/lumina/distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- x11/lumina/distinfo	(revision 385072)
+++ x11/lumina/distinfo	(working copy)
@@ -1,2 +1,2 @@
=2DSHA256 (lumina-0.8.4.tar.bz2) =3D 311114964e900132a09e9acac46958da09d7ff=
b12a3e1d7653147b8952f658f0
=2DSIZE (lumina-0.8.4.tar.bz2) =3D 23261871
+SHA256 (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) =3D 5d54f60a534ea8d922=
59a6f57074173d9721492b7148a5fa5bcf8894beeffaf6
+SIZE (pcbsd-lumina-v0.8.4-Release-P1_GH0.tar.bz2) =3D 23261876

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQF8BAEBCgBmBQJVQrEKXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bLJkIANkZLrhqjR1b1gQyCZ5SLT3d
IC0bdliF1uJtihZvqtBBb6PC8uTqDWLmeH4xvcgwmKehlWLj/4+HlTnjoArT8Adg
tdS1CEDANGLwLB1gsERsn6oKT/4CNgmVBKfOaKpq6BzrZibH1vfL2Gd3bS0Np7s2
ZDJeIj+Zu2WrA0KjMHU3eTeBy2Dss8UTvn+RT5Q2EbS3EPsf7Bsn0tnGIVY+4WEG
pwnblLLdKUfyLCnVsKKRYWMGYRYpGTtNK87/2u4THjBALv4drjSX4tE1LznRiukb
tCK8tWtx9paNB9ifl251oJlpmWxspVJerHo2t16Y2E5cdygsLHOWh2Wz89PAtnw=
=Fjtg
-----END PGP SIGNATURE-----
--=-=-=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?h9rx-w7w6-wny>