Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Jul 1998 23:42:20 +0200
From:      Stefan Esser <se@FreeBSD.ORG>
To:        Brian Somers <brian@Awfulhak.org>, "Marc G. Fournier" <scrappy@FreeBSD.ORG>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-ports@FreeBSD.ORG, Stefan Esser <se@FreeBSD.ORG>
Subject:   Re: cvs commit: ports/audio/kdemultimedia Makefile ports/audio/kdemultimedia/patches patch-a0 patch-ab patch-ac patch-ag patch-ah
Message-ID:  <19980712234220.19661@mi.uni-koeln.de>
In-Reply-To: <199807100030.BAA19304@awfulhak.org>; from Brian Somers on Fri, Jul 10, 1998 at 01:30:23AM %2B0100
References:  <87r9zvpnoj.fsf@ghpc6.ihf.rwth-aachen.de> <199807100030.BAA19304@awfulhak.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 1998-07-10 01:30 +0100, Brian Somers <brian@Awfulhak.org> wrote:
> > "Marc G. Fournier" <scrappy@FreeBSD.ORG> writes:
> > 
> > > scrappy     1998/07/08 20:53:01 PDT
> > > 
> > >   Modified files:
> > >     audio/kdemultimedia  Makefile 
> > >   Removed files:
> > >     audio/kdemultimedia/patches patch-a0 patch-ab patch-ac 
> > >                                 patch-ag patch-ah 
> > >   Log:
> > >   Change to UNBROKEN ...
> > >   Add USE_GMAKE to get past a compile problem in kmid
> > >   Remove patches, as were not required to cleanly compile
> > 
> > Why don't you just wait until Stefan commits the 1.0pre versions for
> > the KDE ports? You could at least contact the maintainer before you
> > jump right in.
> 
> Hmm, I don't wish to criticise the maintainer (I have no idea about 
> his other commitments), but this port along with other kde 4.1-beta 
> ports has been broken for some time.

Sorry, I've been overloaded at work for too long a time already.

> I sent a complete set of patches to bring the whole lot up to 4.1 at 
> one point and got absolutely no reply.

I do remember your mail, and it is still in my INBOX, but I just
had to do much more urgent things that ate my rare spare time.
I'm doing what I can, but I really don't have time to react to 
more than a few mails per day (and often don't have time to even
retrieve mail from my ISP for 10 days or more).

> While I have no doubt that the stuff Stefan is doing is far more 
> thorough than what I did, I have to agree with ``scrappy'' - it's 
> broken, so fix it.  Besides, shipping 2.2.7 w/ broken ports will look 
> a bit silly :-/

Yes, but I have already invested quite a number of hours (didn't
count them) to prepare a complete set of Pre-1 ports. In fact,
the patches relative to 4.1 that Thomas Gellekum sent were quite
complete, but I just test them on my system, check the LIB_DEPENDS
(which were the only thing I had to fix in Thomas' patches ;-)
and compile with different prefixes and then finally on a system
with all traces of KDE removed, just to be sure that dependencies
work. This takes many tens of hours in total (4 compilations plus
time to actually fix things).
I really should have gotten me a faster machine than my old 486, 
but it does its job for everything else except building giant
ports like the complete KDE.

The problem with the switch from Beta-4 to 1.0-Pre is, that I
can't easily test whether Beta-4 kdeutils, kdenetwork, ... will 
compile with 1.0-Pre headers and libraries. Testing compatibility
would take nearly as long as the upgrade of all the KDE ports.

Since ports and packages are built automagically, I had to mark
all of the Beta-4 based ports that I've not yet finished as BROKEN,
while they are in fact still quite functional. (I had less trouble
with Beta-4 over the last month than with 1.0-Pre in just a few
days.)

I did not commit any update to 1.0-Pre because I did not yet have
all of the parts ready. And as the maintainer I think its up to
me, when I actually commit a new version !


Regarding the "upgrade" of the kdemultimedia port:

You can fix anything on your system, you can send me patches or
submit your patches with send-pr, you can complain loudly on the
mail lists, but please do not remove patches that are meant to
remove the dependency on some non-standard build tool (GNU make
in this case) without asking.

In fact, your commit made my work harder, since it conflicts with
what I already changed, and I had to clean up the resulting mess.
This does not help to get the updated KDE ports committed earlier :(


Regards, STefan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980712234220.19661>