Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 May 2019 07:37:23 +0200
From:      Antoine Brodin <antoine@freebsd.org>
To:        Conrad Meyer <cem@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12...
Message-ID:  <CAALwa8ni=SNFOXqQ8w-tk1d39ZeMNDyEDg4Q=wAFh_MRRBeesQ@mail.gmail.com>
In-Reply-To: <201905200038.x4K0cNoZ019920@repo.freebsd.org>
References:  <201905200038.x4K0cNoZ019920@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 20, 2019 at 2:38 AM Conrad Meyer <cem@freebsd.org> wrote:
> Author: cem
> Date: Mon May 20 00:38:23 2019
> New Revision: 347984
> URL: https://svnweb.freebsd.org/changeset/base/347984
>
> Log:
>   Extract eventfilter declarations to sys/_eventfilter.h
>
>   This allows replacing "sys/eventfilter.h" includes with "sys/_eventfilter.h"
>   in other header files (e.g., sys/{bus,conf,cpu}.h) and reduces header
>   pollution substantially.
>
>   EVENTHANDLER_DECLARE and EVENTHANDLER_LIST_DECLAREs were moved out of .c
>   files into appropriate headers (e.g., sys/proc.h, powernv/opal.h).
>
>   As a side effect of reduced header pollution, many .c files and headers no
>   longer contain needed definitions.  The remainder of the patch addresses
>   adding appropriate includes to fix those files.
>
>   LOCK_DEBUG and LOCK_FILE_LINE_ARG are moved to sys/_lock.h, as required by
>   sys/mutex.h since r326106 (but silently protected by header pollution prior
>   to this change).
>
>   No functional change (intended).  Of course, any out of tree modules that
>   relied on header pollution for sys/eventhandler.h, sys/lock.h, or
>   sys/mutex.h inclusion need to be fixed.  __FreeBSD_version has been bumped.

Hi,

Why request an exp-run and commit the patch before the exp-run has finished?

Cheers,

Antoine



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8ni=SNFOXqQ8w-tk1d39ZeMNDyEDg4Q=wAFh_MRRBeesQ>