Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Jan 2021 21:52:12 +0000
From:      bugzilla-noreply@freebsd.org
To:        gnome@FreeBSD.org
Subject:   [Bug 252379] Mk/Uses/compiler.mk: remove USE_GCC=yes for compiler:openmp due to libomp.so is part of base since 11.3/12.1
Message-ID:  <bug-252379-6497-U2eHphMIut@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-252379-6497@https.bugs.freebsd.org/bugzilla/>
References:  <bug-252379-6497@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252379

--- Comment #22 from Jason W. Bacon <jwb@freebsd.org> ---
I've updated all my ports using openmp to eliminate the gcc dep.  Below is a
summary of the necessary changes to show some examples of what we're up
against.

I plan to do some runtime testing before committing these changes.

=3D=3D=3D

/usr/ports/biology/canu/Makefile:MAINTAINER=3D    jwb@FreeBSD.org

Requires both openmp and c++11:

-USES=3D          compiler:openmp gmake perl5
+USES=3D          compiler:c++11-lang gmake localbase perl5

No longer needed since replacing compiler:openmp with compiler:c++11-lang:

-.include <bsd.port.pre.mk>
-
-# GCC 4.2.1 (still base compiler on some 2nd tier platforms) cannot build =
canu
-.if ${COMPILER_TYPE} =3D=3D gcc && ${COMPILER_VERSION} <=3D 42
-USE_GCC=3D       yes
-.endif
-

=3D=3D=3D

/usr/ports/biology/cd-hit/Makefile:MAINTAINER=3D  jwb@FreeBSD.org

Requires openmp only:

-USES=3D          compiler:openmp gmake shebangfix
+USES=3D          gmake shebangfix

/usr/ports/biology/fasttree/Makefile:MAINTAINER=3D        jwb@FreeBSD.org

Requires openmp only:

-USES=3D          compiler:openmp

=3D=3D=3D

/usr/ports/biology/gcta/Makefile:MAINTAINER=3D    jwb@FreeBSD.org

Requires both openmp and c++11:

-USES=3D          compiler:openmp dos2unix eigen:3 gmake localbase zip
+USES=3D          compiler:c++11-lang dos2unix eigen:3 gmake localbase:ldfl=
ags
zip

No longer needed since replacing compiler:openmp with compiler:c++11-lang:

-.include <bsd.port.pre.mk>
-
-.if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc && ${COMPILER_VERSION} <=3D 42
-USE_GCC=3D       yes
-.endif
-

=3D=3D=3D

/usr/ports/biology/ncbi-blast+/Makefile:MAINTAINER=3D     jwb@FreeBSD.org

Requires both openmp and c++14:

-USES=3D          compiler:openmp gmake shebangfix perl5 python
+USES=3D          compiler:c++14-lang gmake shebangfix perl5 python
-LDFLAGS+=3D      -latomic

-latomic required for gcc, does not work with clang:

-# Force newer GCC on platforms using GCC 4.2 as base
 .if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc
-USE_GCC=3D       yes
+# In case of problems:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220822
+LDFLAGS+=3D      -latomic # Only exists in gcc libs
 .endif

=3D=3D=3D

/usr/ports/biology/stacks/Makefile:MAINTAINER=3D  jwb@FreeBSD.org

-USES=3D          compiler:openmp gmake python shebangfix
+USES=3D          compiler:c++11-lang gmake python shebangfix

clang is missing some atomic functionality on i386:

-# Force newer GCC on platforms using GCC 4.2 as base
-.if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc
+# Temp workaround, see PR 230888
+.if ${ARCH} =3D=3D i386
 USE_GCC=3D       yes
 .endif

=3D=3D=3D

/usr/ports/biology/star/Makefile:MAINTAINER=3D    jwb@FreeBSD.org

Requires both openmp and c++11:

-USES=3D          compiler:openmp gmake
+USES=3D          compiler:c++11-lang gmake

No longer needed since replacing compiler:openmp with compiler:c++11-lang:

-.include <bsd.port.pre.mk>
-
-# Force newer compiler on platforms using GCC 4.2 as base
-.if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc && ${COMPILER_VERSION} <=3D 42
-USE_GCC=3D       yes
-.endif
-

=3D=3D=3D

/usr/ports/sysutils/parafly/Makefile:MAINTAINER=3D        jwb@FreeBSD.org

Requires openmp only:

-USES=3D          compiler:openmp tar:tgz
+USES=3D          tar:tgz

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252379-6497-U2eHphMIut>