Date: Sat, 12 Oct 2013 05:30:17 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Cc: portmgr@FreeBSD.org Subject: ports/182919: [PATCH] Portlint port standard updates and maintainership to portmgr Message-ID: <201310121030.r9CAULve084039@freefall.freebsd.org> Resent-Message-ID: <201310121040.r9CAe0Rr085703@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182919
>Category: ports
>Synopsis: [PATCH] Portlint port standard updates and maintainership to portmgr
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 12 10:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Bryan Drewery
>Release: FreeBSD 8.3-RELEASE-p5 i386
>Organization:
>Environment:
>Description:
portlint is a critical tool for port development. We have been making a lot of changes lately that
portlint fails to properly find or recommend. The recent ports/181359 one that recommended
USES=gmake to use USES=${GMAKE} and USE_GMAKE was especially wrong. We need more people to be able
to approve or work on getting updates into portlint faster.
- Support staging
- Remove indefinite article from COMMENT
- Pass maintainership to portmgr
>How-To-Repeat:
>Fix:
--- portlint-updates-portmgr.txt begins here ---
Index: Makefile
===================================================================
--- Makefile (revision 330124)
+++ Makefile (working copy)
@@ -7,8 +7,8 @@ CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
-MAINTAINER= marcus@FreeBSD.org
-COMMENT= A verifier for FreeBSD port directory
+MAINTAINER= portmgr@FreeBSD.org
+COMMENT= Verifier for FreeBSD port directory
NO_BUILD= yes
WRKSRC= ${WRKDIR}/src
@@ -17,15 +17,16 @@ USE_PERL5= run
SRC= ${.CURDIR}/src
-MAN1= portlint.1
-PLIST_FILES= bin/portlint
+PLIST_FILES= bin/portlint \
+ man/man1/portlint.1.gz
-.if !defined(NOPORTEXAMPLES)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MEXAMPLES}
PLIST_FILES+= %%EXAMPLESDIR%%/portlintgrep
PLIST_DIRS= %%EXAMPLESDIR%%
.endif
-NO_STAGE= yes
do-fetch:
@${DO_NADA}
@@ -38,11 +39,15 @@ post-patch:
${WRKSRC}/portlintgrep.pl
do-install:
- ${INSTALL_SCRIPT} ${WRKSRC}/portlint.pl ${PREFIX}/bin/portlint
- ${INSTALL_MAN} ${WRKSRC}/portlint.1 ${MAN1PREFIX}/man/man1
-.if !defined(NOPORTEXAMPLES)
- ${INSTALL} -o ${SHAREOWN} -g ${SHAREGRP} -m ${BINMODE} -d ${EXAMPLESDIR}
- ${INSTALL_SCRIPT} ${WRKSRC}/portlintgrep.pl ${EXAMPLESDIR}/portlintgrep
+ ${INSTALL_SCRIPT} ${WRKSRC}/portlint.pl \
+ ${STAGEDIR}${PREFIX}/bin/portlint
+ ${INSTALL_MAN} ${WRKSRC}/portlint.1 \
+ ${STAGEDIR}${MAN1PREFIX}/man/man1
+.if ${PORT_OPTIONS:MEXAMPLES}
+ ${INSTALL} -o ${SHAREOWN} -g ${SHAREGRP} -m ${BINMODE} -d \
+ ${STAGEDIR}${EXAMPLESDIR}
+ ${INSTALL_SCRIPT} ${WRKSRC}/portlintgrep.pl \
+ ${STAGEDIR}${EXAMPLESDIR}/portlintgrep
.endif
.include <bsd.port.mk>
--- portlint-updates-portmgr.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310121030.r9CAULve084039>