Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Oct 2019 22:19:56 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r353673 - head/sys/conf
Message-ID:  <201910162219.x9GMJuo8045682@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Wed Oct 16 22:19:56 2019
New Revision: 353673
URL: https://svnweb.freebsd.org/changeset/base/353673

Log:
  Formalize the use of linker scripts for kernel modules.
  
  Automatically apply ldscript.kmod.${MACHINE_ARCH} if it exists.
  We already have an i386-specific linker script; rename it accordingly.
  
  Note that the linker script is applied when the object files are
  partially linked.  (For amd64 this is also the final link.)
  
  Reviewed by:	imp, kib
  Discussed with:	jhb
  MFC after:	1 week
  Sponsored by:	Netflix
  Differential Revision:	https://reviews.freebsd.org/D21887

Added:
  head/sys/conf/ldscript.kmod.i386
     - copied unchanged from r353672, head/sys/conf/ldscript.set_padding
Deleted:
  head/sys/conf/ldscript.set_padding
Modified:
  head/sys/conf/kmod.mk

Modified: head/sys/conf/kmod.mk
==============================================================================
--- head/sys/conf/kmod.mk	Wed Oct 16 22:12:34 2019	(r353672)
+++ head/sys/conf/kmod.mk	Wed Oct 16 22:19:56 2019	(r353673)
@@ -242,18 +242,16 @@ EXPORT_SYMS?=	NO
 CLEANFILES+=	export_syms
 .endif
 
+.if !defined(FIRMWS) && exists(${SYSDIR}/conf/ldscript.kmod.${MACHINE_ARCH})
+_LDFLAGS+=-T ${SYSDIR}/conf/ldscript.kmod.${MACHINE_ARCH}
+.endif
+
 .if ${__KLD_SHARED} == yes
 ${KMOD}.kld: ${OBJS}
 .else
 ${FULLPROG}: ${OBJS}
 .endif
-.if !defined(FIRMWS) && (${MACHINE_CPUARCH} == "i386")
-	${LD} -m ${LD_EMULATION} ${_LDFLAGS} -r \
-	    -T ${SYSDIR}/conf/ldscript.set_padding \
-	    -d -o ${.TARGET} ${OBJS}
-.else
 	${LD} -m ${LD_EMULATION} ${_LDFLAGS} -r -d -o ${.TARGET} ${OBJS}
-.endif
 .if ${MK_CTF} != "no"
 	${CTFMERGE} ${CTFFLAGS} -o ${.TARGET} ${OBJS}
 .endif

Copied: head/sys/conf/ldscript.kmod.i386 (from r353672, head/sys/conf/ldscript.set_padding)
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/sys/conf/ldscript.kmod.i386	Wed Oct 16 22:19:56 2019	(r353673, copy of r353672, head/sys/conf/ldscript.set_padding)
@@ -0,0 +1,46 @@
+/*-
+ * SPDX-License-Identifier: BSD-2-Clause
+ *
+ * Copyright (c) 2018 Bjoern A. Zeeb
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ *
+ * $FreeBSD$
+ */
+SECTIONS
+{
+	set_pcpu	:
+	{
+		*(set_pcpu)
+		LONG(0x90909090) ;
+	}
+}
+
+SECTIONS
+{
+	set_vnet	:
+	{
+		*(set_vnet)
+		LONG(0x90909090) ;
+	}
+}
+/* end */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910162219.x9GMJuo8045682>