Date: Sun, 20 Mar 2005 20:34:24 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Trevor Johnson <trevor@jpj.net> Cc: Kirill Ponomarew <krion@voodoo.oberon.net> Subject: Re: cvs commit: ports/print/acroread Makefile distinfo pkg-deinstall pkg-descr pkg-install pkg-plist ports/print/acroread/files patch-aa Message-ID: <20050320203424.1440a1a0@Magellan.Leidinger.net> In-Reply-To: <20050317144314.B9327@blues.jpj.net> References: <200503161535.j2GFZGHa081152@repoman.freebsd.org> <20050316163958.GK88584@voodoo.oberon.net> <20050316224313.GB52092@uriah.heep.sax.de> <20050317064656.GA5247@pcwin002.win.tue.nl> <20050317083502.GA3808@uriah.heep.sax.de> <20050317084322.GC5247@pcwin002.win.tue.nl> <20050317144314.B9327@blues.jpj.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 17 Mar 2005 14:55:20 -0500 (EST)
Trevor Johnson <trevor@jpj.net> wrote:
[Thread moved to freebsd-emulation@]
> Stijn Hoop wrote:
>
> > OK, good question. I misunderstood your commit message and thought
> > that anyone who had installed emulators/linux_base-* would also have
> > enabled linux compatability; so that print/acroread/Makefile was
> > missing something along the lines of USE_LINUX=yes. Having read the
> > diffs, it appears there's not much more you can do.
>
> Since bsd.port.mk 1.505, USE_LINUX adds a dependency on a particular
> linux_base port and setting it to "yes" selects the Red Hat 8 one. It
> isn't necessary here because acroread depends upon other Linux ports.
acroread depends upon the linux libc, libm and some other libs from the
linux base. So a dependency is clearly not wrong. Since we add direct
dependencies to the ports also to be able to determine those ports which
may need a rebuild on some major changes, acroread needs to have an
USE_LINUX entry.
I've noticed that you removed some USE_LINUX=yes lines from some linux
ports with the commit log "Respect the user's USE_LINUX setting." This
is the wrong fix for your/our needs. Using USE_LINUX?=yes looks more
correct to me. I try to test this later in the evening. If it works as
expected I try to also get time to patch all ports and commit the fix
tonight, since 1. I can't commit it till the next weekend, 2. you can't
commit it and 3. the ports freeze starts soon and we want the ports
collection to be in good shape for 5.4-Release. Point 1 and 3 are also
the reason why I will not provide a diff for review on
freebsd-emulation, which every change which touches such a large amount
of ports should provide. I will be reachable via mail in case something
breaks.
Bye,
Alexander.
--
To boldly go where I surely don't belong.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050320203424.1440a1a0>