Date: Thu, 24 Dec 2015 00:14:02 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Adam Weinberger <adamw@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404326 - head/shells/zsh Message-ID: <20151223231402.GF20454@ivaldir.etoilebsd.net> In-Reply-To: <201512232256.tBNMukWr007966@repo.freebsd.org> References: <201512232256.tBNMukWr007966@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Il7n/DHsA0sMLmDu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 23, 2015 at 10:56:46PM +0000, Adam Weinberger wrote: > Author: adamw > Date: Wed Dec 23 22:56:46 2015 > New Revision: 404326 > URL: https://svnweb.freebsd.org/changeset/ports/404326 >=20 > Log: > Partially revert r403755. It can't build the curses module against ncur= ses from > ports. It probably can, but configure is too smart to figure that out. > =20 > I have no confidence that linking against curses from ports results in = a properly > working zshell. So, for now, back out the change. It will build a share= d lib zsh > against ncurses from ports, but breaks statically-linked zsh's. Mark th= e port > as IGNORE if we're using ncurses from ports and building a static zsh. > =20 > Also, remove a regression-test target that isn't useful anymore (thanks= to bapt > for the reminder about this). > =20 > I am not enthused about this change. It doesn't really "fix" the below = PR, so > much as shoot ourselves in the other foot instead. > =20 > PR: 205500 >=20 The solution is to make --with-term-lib=3D"tinfow tinfo" only when building= static because when building static you will never build the curses module something like --with-term-lib=3D"${TERMLIB}" TERMLIB=3D"ncursesw ncurses" then later: =2Eif ${PORT_OPTIONS:MSTATIC} TERMLIB=3D"tinfow tinfo" =2Eendif Which will also fix static building with base the day we split libtinfo* fr= om libncurses, which would be nice to do in base :) Best regards, Bapt --Il7n/DHsA0sMLmDu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWeyq6AAoJEGOJi9zxtz5aqe4QALdHJiOUQ0QwcH+Y6NCCz+Bf ltc6/tBWkj4a1gUEpx5SEAHEWuF2hLsHP2s/fgiC/+E1vTntut+c2SzaB1a32wy0 phqO+AjNiGwCBLmBL5jn+XoqkQ3Ir0RPe7VdQOWUMbsRDXsFIZ6BCER9Tv+P5y4C bpzPfvPKf1R75Xo4khl6ZNit6v8N/FktgfYXvHHgqGxv3237U5ee07hPNsWG8CPc 4AvUhcKbjBxGi5B9KjUM/CVqRcIrqucEiqpjmbN8Gi4poNljog+hC8IoNtLJgZwB B9QiVf/NtcPawNbeUbjyAxsqFRjjR31AgR59BegDJcTKqnlvNPlJw4+xPYE0yMz5 0HiZrtGJcJHX5Qs7722jDp51Q/dAC9YiBwkK7D1e56CeA6HKY5Z3mJmrFWtVVLMR JM0sLYtFbusPVL9fFyKDnrfckEeNZ6Q+jGLY3vxGfrPjCBRH+JxceHcOlBOPiD6c FA4ZGXL6R4kfZxEo6AAKZeMS2MvT29PrWTSwrSvvfrOPSun+dELtMYNGaXXJLNN8 nUqQh4UhRWGerQGBA6f0Lrw6wDmsy1/0imAV7ByrLYPvFL6KMKXqZyq4fkpqmmQF rYIaoGj2FR+tJzBfKqRD1D2jbg3TZegRjiIwH51oD/KmIOqTqeEz0KYM+NiTqL5x buo1K4+rCtUtA8g92nEq =9IEN -----END PGP SIGNATURE----- --Il7n/DHsA0sMLmDu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151223231402.GF20454>