Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Jul 2013 14:37:45 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Johan van Selst <johans@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r323298 - head/games/ltris
Message-ID:  <20130719143745.GA81905@FreeBSD.org>
In-Reply-To: <201307191429.r6JETuEb004689@svn.freebsd.org>
References:  <201307191429.r6JETuEb004689@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 19, 2013 at 02:29:56PM +0000, Johan van Selst wrote:
> New Revision: 323298
> URL: http://svnweb.freebsd.org/changeset/ports/323298
> 
> Log:
>   Don't use "inline" keyword in header files for external functions
>   Fixes compilation with clang
> 
> Modified:
>   head/games/ltris/Makefile
> 
> Modified: head/games/ltris/Makefile
> ==============================================================================
> --- head/games/ltris/Makefile	Fri Jul 19 14:28:59 2013	(r323297)
> +++ head/games/ltris/Makefile	Fri Jul 19 14:29:56 2013	(r323298)
> @@ -31,6 +31,8 @@ post-patch:
>  	@${REINPLACE_CMD} -e 's|/icons|/pixmaps|g' ${WRKSRC}/Makefile.in
>  	@${REINPLACE_CMD} -e 's|= @mixer_flag@|= @INTLLIBS@ @mixer_flag@|g ; \
>  		 s|--mode=666||g' ${WRKSRC}/src/Makefile.in
> +	@${REINPLACE_CMD} -e 's/^inline //' \
> +		${WRKSRC}/src/sdl.h ${WRKSRC}/src/tools.h

I might be nit picking, but it's generally advised and preferred to use the
same separators for regex' that were previously used (that is, bars instead
of slashes here) in the Makefile, for consistency's sake.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130719143745.GA81905>