Date: Wed, 08 Jul 2009 07:58:20 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Marcel Moolenaar <marcel@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r195436 - in head/sys: dev/ata geom geom/part sys Message-ID: <92653.1247039900@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 08 Jul 2009 05:56:14 GMT." <200907080556.n685uFsn040044@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200907080556.n685uFsn040044@svn.freebsd.org>, Marcel Moolenaar writ es: >Log: > Revert revisions 188839 and 188868. Use of the ioctl in geom_dev.c > is invalid because the ioctl happens without prior open. The ioctl > got introduced to provide backward compatibility for extended > partitions, but it ended up not being used because it didn't work > as expected. Since there are no consumers of the ioctl and the > implementation is broken, the best fix is to remove the code > entirely. > > Spotted by: phk For the record Really spotted by: scottl -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?92653.1247039900>